Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubevirt IPAM controller: Deploy Passt CNI binary #1829

Merged
merged 2 commits into from
Jul 24, 2024
Merged

kubevirt IPAM controller: Deploy Passt CNI binary #1829

merged 2 commits into from
Jul 24, 2024

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Jul 21, 2024 •
edited
Loading

What this PR does / why we need it:
As part of kubevirt ipam controller deploy, deploy also
the Passt binding CNI binary to the nodes, via a DaemonSet.

Special notes for your reviewer:

Release note:

Support deploying Passt binding CNI

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 21, 2024
@kubevirt-bot kubevirt-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L labels Jul 21, 2024
@oshoval oshoval mentioned this pull request Jul 21, 2024
Merged
8 tasks
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 21, 2024
@oshoval oshoval changed the title WIP Deploy Passt binary WIP Deploy Passt CNI binary Jul 21, 2024
@oshoval
Copy link
Collaborator Author

oshoval commented Jul 21, 2024

/test pull-e2e-cluster-network-addons-operator-br-marker-functests

@oshoval oshoval force-pushed the passt branch 2 times, most recently from c7717c3 to 2def1ab Compare July 23, 2024 15:23
@oshoval
passt: Deploy Passt binding CNI
23aa473 
As part of kubevirt ipam controller deploy, deploy also
the Passt binding CNI binary to the nodes, via a DaemonSet.

Signed-off-by: Or Shoval <oshoval@redhat.com>
@oshoval oshoval changed the title WIP Deploy Passt CNI binary kubevirt IPAM controller: Deploy Passt CNI binary Jul 23, 2024
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2024
@oshoval oshoval mentioned this pull request Jul 23, 2024
Closed
@oshoval
Copy link
Collaborator Author

oshoval commented Jul 23, 2024

@qinqon
Can you please review?
Thanks

qinqon
qinqon approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@qinqon qinqon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2024
@oshoval
e2e,workflow: Increase condition waiting timeout
6f379eb 
We wait one minute and expect the config status to be Progressing.
In the first time we deploy, images should be pulled,
and then some resources fail to be created because they need a secret
that is not created yet, and will auto retry later.

The fact that they failed change the state from Progressing to Failed,
waiting more allows giving eventually consistent to do its magic,
and it will overcome this flakiness.

Signed-off-by: Or Shoval <oshoval@redhat.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
@oshoval
Copy link
Collaborator Author

oshoval commented Jul 24, 2024 •
edited
Loading

Thanks
one test failed, due to flakiness not related to this PR specifically, but a problem i saw every now and then
pushed a commit to address it (info on the commit message)
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1829/pull-e2e-cluster-network-addons-operator-workflow-k8s/1815770470532780032

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@oshoval oshoval requested a review from qinqon July 24, 2024 07:17
@qinqon
Copy link
Collaborator

qinqon commented Jul 24, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
@kubevirt-bot kubevirt-bot merged commit 22bae2a into kubevirt:main Jul 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoracek phoracek Awaiting requested review from phoracek

@qinqon qinqon Awaiting requested review from qinqon

Assignees

@qinqon qinqon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oshoval @kubevirt-bot @qinqon