Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump bridge-marker to 0.11.2 #1850

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Conversation

kubevirt-bot
Copy link
Collaborator

bump bridge-marker to 0.11.2
Executed by Bumper script

bump bridge-marker to 0.11.2

Signed-off-by: CNAO Bump Bot <noreply@github.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 9, 2024
@oshoval
Copy link
Collaborator

oshoval commented Aug 11, 2024

@RamLavi

  Full Stack Trace
    github.com/onsi/gomega/internal.(*AsyncAssertion).buildActualPoller.func3.1()
    	/tmp/cnao/cluster-network-addons-operator/vendor/github.com/onsi/gomega/internal/async_assertion.go:321 +0x186
    panic({0x16c5900?, 0x28778a0?})
    	/tmp/cnao/cluster-network-addons-operator/build/_output/bin/go/src/runtime/panic.go:770 +0x132
    github.com/kubevirt/cluster-network-addons-operator/test/check.isKindNotFound({0x0?, 0x0?})

Please take a look
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1850/pull-e2e-cluster-network-addons-operator-lifecycle-k8s/1821941283426406400#1:build-log.txt%3A871

this should fix it
#1852
as err == nil there

@oshoval
Copy link
Collaborator

oshoval commented Aug 11, 2024

will retest once #1852 is merged

the other flake didnt happen, and seems Prometheus isnt related to this PR

@oshoval
Copy link
Collaborator

oshoval commented Aug 11, 2024

not sure why it was closed (just because i wrote fixes ....)
reopening

@oshoval oshoval reopened this Aug 11, 2024
Copy link

sonarcloud bot commented Aug 11, 2024

@oshoval
Copy link
Collaborator

oshoval commented Aug 11, 2024

/lgtm
/approve

lets just see all is passing now

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2024
@kubevirt-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2024
@kubevirt-bot kubevirt-bot merged commit f54ea55 into main Aug 11, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants