Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add flag for setting timeout for creating windows vms #253

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented Sep 25, 2024

What this PR does / why we need it:
some Windows images require more time to download image.
This commit adds new flag windows-ready-timeout, which
will allow user to set higher timeout only for Windows VMs.
All other OS distributions will use default timeout.

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 25, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lyarwood for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -23,7 +23,7 @@ import (
)

const (
vmReadyTimeout = 300 * time.Second
vmReadyTimeout = 900 * time.Second
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been reported as an issue downstream somewhere?

I assume the issue is mostly with the huge size of the DVs being created rather than the time the OS takes to start and become ready?

I'd much prefer to either have a dedicated constant for the impacted Windows tests or have the ability to pass in a custom timeout into the test binary somehow for downstream to manage this. That might even allow us to lower the timeout for the other tests from the current 5 minutes that seems excessive.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This came from my investigation when I tried the new images.
I added new flag windows-ready-timeout by which the user can set higher timeout only for Windows VMs.

some Windows images require more time to download image.
This commit adds new flag windows-ready-timeout, which
will allow user to set higher timeout only for Windows VMs.
All other OS distributions will use default timeout.

Signed-off-by: Karel Simon <ksimon@redhat.com>
@ksimon1 ksimon1 changed the title chore: increase timeout for creting windows vms chore: Add flag for setting timeout for creating windows vms Sep 26, 2024
@jcanocan
Copy link

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants