-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add flag for setting timeout for creating windows vms #253
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tests/functests/instancetype_test.go
Outdated
@@ -23,7 +23,7 @@ import ( | |||
) | |||
|
|||
const ( | |||
vmReadyTimeout = 300 * time.Second | |||
vmReadyTimeout = 900 * time.Second |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this been reported as an issue downstream somewhere?
I assume the issue is mostly with the huge size of the DVs being created rather than the time the OS takes to start and become ready?
I'd much prefer to either have a dedicated constant for the impacted Windows tests or have the ability to pass in a custom timeout into the test binary somehow for downstream to manage this. That might even allow us to lower the timeout for the other tests from the current 5 minutes that seems excessive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This came from my investigation when I tried the new images.
I added new flag windows-ready-timeout by which the user can set higher timeout only for Windows VMs.
some Windows images require more time to download image. This commit adds new flag windows-ready-timeout, which will allow user to set higher timeout only for Windows VMs. All other OS distributions will use default timeout. Signed-off-by: Karel Simon <ksimon@redhat.com>
68b2db4
to
c6ffcb4
Compare
/lgtm |
What this PR does / why we need it:
some Windows images require more time to download image.
This commit adds new flag windows-ready-timeout, which
will allow user to set higher timeout only for Windows VMs.
All other OS distributions will use default timeout.
Release note: