Rename parameters to DATA_SOURCE_NAME and DATA_SOURCE_NAMESPACE

[akrejcir]

What this PR does / why we need it:
Rename from SRC_PVC_NAME to DATA_SOURCE_NAME,
and from SRC_PVC_NAMESPACE to DATA_SOURCE_NAMESPACE.

Release note:

Renamed parameters in templates.

[borod108]

/lgtm

[ksimon1]

@akrejcir UI is ready for this change?

[akrejcir]

They are working on it right now.

[akrejcir]

Waiting for UI
/hold

[dominikholler]

@akrejcir Can you please share the motivation for this change in the commit message?

[dominikholler]

@akrejcir Can you please share the motivation for this change in the commit message?
@yaacov Is UI ready to get this update?

[yaacov]

@yaacov Is UI ready to get this update?

No, unfortunately the current UI assume the PVC source is in a parameter called SRC_PVC_NAME/NAMESPCE

p.s. Once we move to using parameters "as is" this will no longer be a problem, but in 4.10 the parameter name is hardcoded in the UI.

[dominikholler]

No, unfortunately the current UI assume the PVC source is in a parameter called SRC_PVC_NAME/NAMESPCE
p.s. Once we move to using parameters "as is" this will no longer be a problem, but in 4.10 the parameter name is hardcoded in the UI.

@yaacov Do you plan to modify the name of the parameter in 4.10 ?

[yaacov]

@yaacov Do you plan to modify the name of the parameter in 4.10 ?

We didn't know about the name change, so we didn't make any plans

Note I:
if we do support it, we will have to support both conventions, and check for both names because we need to be backword compatible,
Note II:
It will be nice if we wait with the name change to 4.11, where we plan to remove the practice of giving meaning to template parameters in the UI (CNV-14778)

cc:// @tnisan

[ksimon1]

/lgtm
/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ksimon1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ksimon1]

/hold cancel

[ksimon1]

/cherrypick release-v0.19
Backporting forgotten PR

[kubevirt-bot]

@ksimon1: new pull request created: #467

In response to this:

/cherrypick release-v0.19
Backporting forgotten PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.