Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark CentOS 6 template as deprecated #410

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Mark CentOS 6 template as deprecated #410

merged 1 commit into from
Mar 9, 2022

Conversation

0xFelix
Copy link
Member

@0xFelix 0xFelix commented Feb 11, 2022 •
edited
Loading

What this PR does / why we need it:

CentOS 6 is EOL and therefore marked as deprecated.

The deprecated templates notice, which was removed in 4e48e4e, is
restored.

Release note:

Mark CentOS 6 templates as deprecated

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 11, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 11, 2022

Hi @0xFelix. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 11, 2022
@0xFelix 0xFelix mentioned this pull request Feb 11, 2022
Merged
@ksimon1
Copy link
Member

ksimon1 commented Feb 11, 2022

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 11, 2022
@kubevirt-bot kubevirt-bot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 11, 2022
@ksimon1
Copy link
Member

ksimon1 commented Feb 11, 2022

/retest

@0xFelix
Copy link
Member Author

0xFelix commented Feb 14, 2022

/retest-required

@dominikholler
Copy link
Collaborator

Are you aware of any dependencies to this template @lersek @rwmjones ?

@rwmjones
Copy link

I don't understand what the question means.

@ksimon1
Copy link
Member

ksimon1 commented Feb 14, 2022

@rwmjones we are removing centos6 template. Are you aware of some tests, functionality, or something else which is using centos 6 template?

@rwmjones
Copy link

Nothing I know of, but I don't know much about kubevirt so I may not be the best person to ask.

@lersek
Copy link

lersek commented Feb 14, 2022

same response from me...

@dominikholler
Copy link
Collaborator

thanks for having a look @lersek @rwmjones!
I want to ensure, that the v2v/konveyor/mtv tools does not depend on the centos 6 template.

@mansam are you aware of dependencies in konveyor to the centos 6 template.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2022
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2022
@ksimon1
Copy link
Member

ksimon1 commented Feb 28, 2022

@mansam can you please confirm if there are some dependencies to centos 6 template in konveyor?

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2022
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2022
@mansam
Copy link

mansam commented Feb 28, 2022

Hi, apologies for not seeing this sooner. We don't have any hard dependencies on the centos6 template; Forklift will use it if it's available, but not having it won't break us.

@0xFelix
Copy link
Member Author

0xFelix commented Mar 2, 2022

@yaacov @mansam Does the UI look for the template.kubevirt.io/deprecated: "true" label? Does the UI hide templates when the label is found? Maybe we could add the label to the CentOS 6 template instead of deleting it. This way the UI would not encourage users to create new VMs with obsolete OSes while Forklift could still use the template to migrate legacy VMs.

@0xFelix
Mark CentOS 6 template as deprecated
1500105 
CentOS 6 is EOL and therefore marked as deprecated.

The deprecated templates notice, which was removed in 4e48e4e, is
restored.

Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
@0xFelix 0xFelix changed the title Remove CentOS 6 templates Mark CentOS 6 template as deprecated Mar 9, 2022
@0xFelix
Copy link
Member Author

0xFelix commented Mar 9, 2022

@dominikholler: @yaacov confirmed that deprecated templates are hidden by the ui. I changed the PR so CentOS 6 is marked as deprecated instead of removing it.

@yaacov
Copy link
Contributor

yaacov commented Mar 9, 2022

LGTM

@ksimon1
Copy link
Member

ksimon1 commented Mar 9, 2022

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2022
@kubevirt-bot kubevirt-bot merged commit f3b4cf3 into kubevirt:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borod108 borod108 Awaiting requested review from borod108

@ksimon1 ksimon1 Awaiting requested review from ksimon1

Assignees

@ksimon1 ksimon1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@0xFelix @ksimon1 @dominikholler @rwmjones @lersek @mansam @yaacov @kubevirt-bot