Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Ubuntu template #412

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Improve Ubuntu template #412

merged 1 commit into from
Feb 17, 2022

Conversation

0xFelix
Copy link
Member

@0xFelix 0xFelix commented Feb 14, 2022 •
edited
Loading

What this PR does / why we need it:

  • Add server workload to template and make it the default
  • Remove unnecessary tiny flavor
  • Automatically load active Ubuntu versions

Release note:

Added Ubuntu server workload as new default
Removed Ubuntu tiny flavor
Include support for latest and active Ubuntu versions

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 14, 2022
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 14, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2022

Hi @0xFelix. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@0xFelix 0xFelix mentioned this pull request Feb 14, 2022
Closed
@0xFelix
Copy link
Member Author

0xFelix commented Feb 14, 2022

@dominikholler This PR also independent from #406 now.

@0xFelix 0xFelix mentioned this pull request Feb 14, 2022
Merged
@ksimon1
Copy link
Member

ksimon1 commented Feb 15, 2022

/ok-to-test
/lgtm

@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 15, 2022
@kubevirt-bot kubevirt-bot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 15, 2022
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2022
@0xFelix
Copy link
Member Author

0xFelix commented Feb 15, 2022

/retest

@0xFelix
Improve Ubuntu template
b600894 
- Add server workload to template and make it the default
- Remove unnecessary tiny flavor
- Automatically load active Ubuntu versions

Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
@kubevirt-bot kubevirt-bot added size/S and removed lgtm Indicates that a PR is ready to be merged. size/L labels Feb 15, 2022
@0xFelix
Copy link
Member Author

0xFelix commented Feb 15, 2022

/retest-required

@0xFelix
Copy link
Member Author

0xFelix commented Feb 16, 2022

/retest

@dominikholler
Copy link
Collaborator

/lgtm

@0xFelix
Copy link
Member Author

0xFelix commented Feb 16, 2022

/retest

1 similar comment
@0xFelix
Copy link
Member Author

0xFelix commented Feb 16, 2022

/retest

@ksimon1
Copy link
Member

ksimon1 commented Feb 17, 2022

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2022
@kubevirt-bot kubevirt-bot merged commit 37a57ef into kubevirt:master Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borod108 borod108 Awaiting requested review from borod108

@rnetser rnetser Awaiting requested review from rnetser

Assignees

@ksimon1 ksimon1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xFelix @ksimon1 @dominikholler @kubevirt-bot