Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download oc binary from new location and readd intltool #420

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

0xFelix
Copy link
Member

@0xFelix 0xFelix commented Feb 24, 2022

What this PR does / why we need it:

Download the latest stable oc binary in builder/Dockerfile from the new
location on the mirror.

intltool was removed by accident from the dependencies. Readd it.

Release note:

None

Download the latest stable oc binary in builder/Dockerfile from the new
location on the mirror.

Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 24, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2022

Hi @0xFelix. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 24, 2022
@ksimon1
Copy link
Member

ksimon1 commented Feb 24, 2022

/ok-to-test
/lgtm
/approve

@kubevirt-bot kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 24, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 24, 2022
intltool was removed by accident from the dependencies. This breaks the
build.

Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2022
@0xFelix 0xFelix changed the title Download oc binary from new location Download oc binary from new location and readd intltool Feb 24, 2022
@ksimon1
Copy link
Member

ksimon1 commented Feb 24, 2022

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2022
@akrejcir
Copy link
Contributor

This PR fixes the failing CI.

/override ci/prow/e2e-azure-common-templates-unit-tests

@kubevirt-bot
Copy link
Contributor

@akrejcir: Overrode contexts on behalf of akrejcir: ci/prow/e2e-azure-common-templates-unit-tests

In response to this:

This PR fixes the failing CI.

/override ci/prow/e2e-azure-common-templates-unit-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2022

@0xFelix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-common-templates-unit-tests 6995ee3 link true /test e2e-azure-common-templates-unit-tests
ci/prow/e2e-azure-common-templates-windows2012 6995ee3 link true /test e2e-azure-common-templates-windows2012
ci/prow/e2e-azure-common-templates-windows10 6995ee3 link true /test e2e-azure-common-templates-windows10
ci/prow/e2e-azure-common-templates-windows2019 6995ee3 link true /test e2e-azure-common-templates-windows2019
ci/prow/e2e-azure-common-templates-windows2016 6995ee3 link true /test e2e-azure-common-templates-windows2016

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ksimon1
Copy link
Member

ksimon1 commented Feb 24, 2022

Merging to unlock failing ci

@ksimon1 ksimon1 merged commit b6b748a into kubevirt:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants