Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless osinfo-db-override for windows 11 #519

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

fossedihelm
Copy link
Contributor

What this PR does / why we need it:
Windows 11 os info has been included in the osinfo-db repository. https://gitlab.com/libosinfo/osinfo-db/-/merge_requests/362

It is not necessary anymore to use our custom data
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

Windows 11 os info has been included in the osinfo-db
repository. https://gitlab.com/libosinfo/osinfo-db/-/merge_requests/362

It is not necessary anymore to use our custom data

Signed-off-by: fossedihelm <ffossemo@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 13, 2023
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2023
@0xFelix
Copy link
Member

0xFelix commented Mar 13, 2023

/hold Merge after #518

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2023
@fossedihelm
Copy link
Contributor Author

/hold Merge after #518

@0xFelix FYI, previous osinfo-db already contains win11 information, so we don't need to wait for the 518

@0xFelix
Copy link
Member

0xFelix commented Mar 13, 2023

Ok, then let's cancel the hold on this PR.

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2023
@ksimon1
Copy link
Member

ksimon1 commented Mar 19, 2023

/retest

2 similar comments
@ksimon1
Copy link
Member

ksimon1 commented Mar 20, 2023

/retest

@ksimon1
Copy link
Member

ksimon1 commented Mar 20, 2023

/retest

@kubevirt-bot kubevirt-bot merged commit b0f4472 into kubevirt:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants