fix: add bind immediate annotation to test datavolume #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the default storageClass in e2e tests requests WFFC mode. Currently when original datavolume is created in e2e tests, it is in pending state, because there is no object which will consume it. This commit adds special annotation cdi.kubevirt.io/storage.bind.immediate.requested to windows and linux original datavolume, which allows to import datavolume without consumer. Signed-off-by: Karel Šimon <ksimon@redhat.com>
kubevirt-bot
added
release-note-none
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ksimon1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fix: add bind immediate annotation to test datavolume
the default storageClass in e2e tests requests WFFC mode. Currently when original datavolume is created in e2e tests, it is in pending state, because there is no object which will consume it. This commit adds special annotation
cdi.kubevirt.io/storage.bind.immediate.requested
to windows and linux original datavolume,
which allows to import datavolume without consumer.
Release note: