Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom configuration of crio in testing cluster #542

Closed
wants to merge 2 commits into from

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented Aug 1, 2023

What this PR does / why we need it:
our e2e are not working due to permission issue in crio.
cri-o/cri-o#7192 should revert the change.
Until that revert PR is released and available in ci envs, we have to
set special configuration on crio on all nodes
Release note:

NONE

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 1, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 1, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ksimon1. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Aug 1, 2023
@ksimon1
Copy link
Member Author

ksimon1 commented Aug 1, 2023

/test e2e-gcp-common-templates-centos7

@kubevirt-bot
Copy link
Contributor

@ksimon1: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-gcp-common-templates-centos7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ksimon1
Copy link
Member Author

ksimon1 commented Aug 1, 2023

/test e2e-gcp-common-templates-centos7

@kubevirt-bot
Copy link
Contributor

@ksimon1: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-gcp-common-templates-centos7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -70,11 +70,12 @@ function latest_version() {
export KUBEVIRT_VERSION=$(latest_version "kubevirt")

# Latest released CDI version
export CDI_VERSION=$(latest_version "containerized-data-importer")
#export CDI_VERSION=$(latest_version "containerized-data-importer")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's no longer required, we should drop this line to keep the file clean.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just testing PR, which should investigate where is the problem in CI. This change will not be part of result PR

@ksimon1
Copy link
Member Author

ksimon1 commented Aug 1, 2023

/test e2e-gcp-common-templates-centos7

@kubevirt-bot
Copy link
Contributor

@ksimon1: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-gcp-common-templates-centos7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ksimon1
Copy link
Member Author

ksimon1 commented Aug 4, 2023

/test e2e-gcp-common-templates-centos7

@kubevirt-bot
Copy link
Contributor

@ksimon1: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-gcp-common-templates-centos7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ksimon1 ksimon1 force-pushed the fix-ci branch 2 times, most recently from ad8c933 to da0381f Compare August 9, 2023 10:16
@ksimon1
Copy link
Member Author

ksimon1 commented Aug 9, 2023

/test e2e-gcp-common-templates-centos7

@kubevirt-bot
Copy link
Contributor

@ksimon1: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-gcp-common-templates-centos7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

our e2e are not working due to permission issue in crio.
cri-o/cri-o#7192 should revert the change.
Until that revert PR is released and available in ci envs, we have to
set special configuration on crio on all nodes
Signed-off-by: Karel Simon <ksimon@redhat.com>
@ksimon1 ksimon1 changed the title fix: switch to ssd storageClass fix: custom configuration of crio in testing cluster Aug 10, 2023
@ksimon1 ksimon1 marked this pull request as ready for review August 10, 2023 17:54
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2023
@ksimon1
Copy link
Member Author

ksimon1 commented Aug 11, 2023

/test e2e-gcp-common-templates-centos-stream9

@kubevirt-bot
Copy link
Contributor

@ksimon1: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-gcp-common-templates-centos-stream9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ksimon1
Copy link
Member Author

ksimon1 commented Aug 23, 2023

/test e2e-gcp-common-templates-rhel9

@kubevirt-bot
Copy link
Contributor

@ksimon1: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-gcp-common-templates-rhel9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ksimon1 ksimon1 force-pushed the fix-ci branch 2 times, most recently from d1bcf99 to ad3e476 Compare August 24, 2023 11:40
@ksimon1
Copy link
Member Author

ksimon1 commented Aug 25, 2023

/retest

Set requests and limits for CDI
all these changes should help with solving issue, when
import of datavolume is not working

Signed-off-by: Karel Simon <ksimon@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Aug 30, 2023

@ksimon1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-common-templates-windows2012 0aba844 link true /test e2e-gcp-common-templates-windows2012
ci/prow/e2e-gcp-common-templates-centos7 4a2aadb link true /test e2e-gcp-common-templates-centos7
ci/prow/e2e-gcp-common-templates-windows11 4a2aadb link true /test e2e-gcp-common-templates-windows11
ci/prow/e2e-gcp-common-templates-windows10 4a2aadb link true /test e2e-gcp-common-templates-windows10
ci/prow/e2e-gcp-common-templates-windows2019 4a2aadb link true /test e2e-gcp-common-templates-windows2019
ci/prow/e2e-gcp-common-templates-windows2016 4a2aadb link true /test e2e-gcp-common-templates-windows2016
ci/prow/e2e-gcp-common-templates-windows2022 4a2aadb link true /test e2e-gcp-common-templates-windows2022
ci/prow/e2e-gcp-common-templates-rhel9 4a2aadb link true /test e2e-gcp-common-templates-rhel9
ci/prow/e2e-gcp-common-templates-fedora 4a2aadb link true /test e2e-gcp-common-templates-fedora
ci/prow/e2e-gcp-common-templates-rhel7 4a2aadb link true /test e2e-gcp-common-templates-rhel7

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ksimon1
Copy link
Member Author

ksimon1 commented Sep 25, 2023

This PR is no longer needed

@ksimon1 ksimon1 closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants