Annotate Windows Server 2012 as deprecated

[jean-edouard]

What this PR does / why we need it:
This PR adds an annotation to the Windows Server 2012 R2 template to tag it as deprecated.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Windows Server 2012 R2 is now deprecated

[0xFelix]

This will break the script if no TARGET env was provided.

[jean-edouard]

Right, thanks for the review, do you have a preferred default?

[0xFelix]

Let's go with windows2k22 as the current successor.

Please note that this also needs adjustment of the CI jobs in openshift/release. At least the 2k12 lane needs to be removed.

[jean-edouard]

Default fixed, and created openshift/release#42370

[lyarwood]

I'm against this, looking at the docs:

https://learn.microsoft.com/en-us/lifecycle/announcements/windows-server-2012-r2-end-of-support

Windows Server 2012 and Windows Server 2012 R2 will end on October 10, 2023. After this date, these products will no longer receive security updates, non-security updates, bug fixes, technical support, or online technical content updates. If you cannot upgrade to the next version, you will need to use Extended Security Updates (ESUs) for up to three years. ESUs are available for free in Azure or need to be purchased for on-premises deployments. Microsoft has guidance for both cloud and on-premises solutions. Go here to learn more.

So it's still available through EUS, would it be better to mark the templates as deprecated and drop CI coverage for now?

That's going to be my approach in common-instancetypes anyway:

kubevirt/common-instancetypes#99

[jean-edouard]

I'm against this, looking at the docs:

https://learn.microsoft.com/en-us/lifecycle/announcements/windows-server-2012-r2-end-of-support

Windows Server 2012 and Windows Server 2012 R2 will end on October 10, 2023. After this date, these products will no longer receive security updates, non-security updates, bug fixes, technical support, or online technical content updates. If you cannot upgrade to the next version, you will need to use Extended Security Updates (ESUs) for up to three years. ESUs are available for free in Azure or need to be purchased for on-premises deployments. Microsoft has guidance for both cloud and on-premises solutions. Go here to learn more.

So it's still available through EUS, would it be better to mark the templates as deprecated and drop CI coverage for now?

That's going to be my approach in common-instancetypes anyway:

kubevirt/common-instancetypes#99

Done, PTAL!

[lyarwood]

/lgtm

Thanks! If you respin please include the link to the support docs in the commit and description of the PR for context.

[openshift-ci]

@jean-edouard: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-common-templates-centos6	02b0476	link	true	/test e2e-gcp-common-templates-centos6
ci/prow/e2e-gcp-common-templates-ubuntu	02b0476	link	true	/test e2e-gcp-common-templates-ubuntu
ci/prow/e2e-gcp-common-templates-centos-stream9	02b0476	link	true	/test e2e-gcp-common-templates-centos-stream9
ci/prow/e2e-gcp-common-templates-rhel9	02b0476	link	true	/test e2e-gcp-common-templates-rhel9
ci/prow/e2e-gcp-common-templates-centos-stream8	02b0476	link	true	/test e2e-gcp-common-templates-centos-stream8
ci/prow/e2e-gcp-common-templates-rhel7	02b0476	link	true	/test e2e-gcp-common-templates-rhel7
ci/prow/e2e-gcp-common-templates-rhel8	02b0476	link	true	/test e2e-gcp-common-templates-rhel8
ci/prow/e2e-gcp-common-templates-centos7	02b0476	link	true	/test e2e-gcp-common-templates-centos7
ci/prow/e2e-gcp-common-templates-windows10	02b0476	link	true	/test e2e-gcp-common-templates-windows10
ci/prow/e2e-gcp-common-templates-windows11	02b0476	link	true	/test e2e-gcp-common-templates-windows11
ci/prow/e2e-gcp-common-templates-windows2022	02b0476	link	true	/test e2e-gcp-common-templates-windows2022
ci/prow/e2e-gcp-common-templates-windows2019	02b0476	link	true	/test e2e-gcp-common-templates-windows2019
ci/prow/e2e-gcp-common-templates-windows2012	02b0476	link	true	/test e2e-gcp-common-templates-windows2012
ci/prow/e2e-gcp-common-templates-windows2016	02b0476	link	true	/test e2e-gcp-common-templates-windows2016
ci/prow/e2e-gcp-common-templates-fedora	02b0476	link	true	/test e2e-gcp-common-templates-fedora

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[lyarwood]

/lgtm

[0xFelix]

/approve

Thanks!

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [0xFelix]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment