Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove tiny size from e2e test for fedora #610

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix: remove tiny size from e2e test for fedora #610

merged 1 commit into from
Sep 10, 2024

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented Sep 9, 2024

What this PR does / why we need it:
fix: remove tiny size from e2e test for fedora

the fedora tiny size was removed and e2e test is failing because it is trying to create vm with it.

Release note:

NONE

@ksimon1
fix: remove tiny size from e2e test for fedora
52ee681 
the fedora tiny size was removed and e2e test is failing
because it is trying to create vm with it.

Signed-off-by: Karel Simon <ksimon@redhat.com>
@kubevirt-bot kubevirt-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 9, 2024
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Sep 9, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ksimon1. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ksimon1
Copy link
Member Author

ksimon1 commented Sep 9, 2024

/retest

@ksimon1
Copy link
Member Author

ksimon1 commented Sep 10, 2024

/test e2e-gcp-common-templates-centos-stream8

@kubevirt-bot
Copy link
Contributor

@ksimon1: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-gcp-common-templates-centos-stream8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ksimon1
Copy link
Member Author

ksimon1 commented Sep 10, 2024

/test e2e-gcp-common-templates-centos-stream8

@kubevirt-bot
Copy link
Contributor

@ksimon1: No presubmit jobs available for kubevirt/common-templates@master

In response to this:

/test e2e-gcp-common-templates-centos-stream8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ksimon1
Copy link
Member Author

ksimon1 commented Sep 10, 2024

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 10, 2024

@ksimon1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-common-templates-rhel8 52ee681 link true /test e2e-gcp-common-templates-rhel8
ci/prow/e2e-gcp-common-templates-centos-stream9 52ee681 link true /test e2e-gcp-common-templates-centos-stream9
ci/prow/e2e-gcp-common-templates-rhel9 52ee681 link true /test e2e-gcp-common-templates-rhel9
ci/prow/e2e-gcp-common-templates-centos-stream8 52ee681 link true /test e2e-gcp-common-templates-centos-stream8
ci/prow/e2e-gcp-common-templates-rhel7 52ee681 link true /test e2e-gcp-common-templates-rhel7
ci/prow/e2e-gcp-common-templates-centos7 52ee681 link true /test e2e-gcp-common-templates-centos7
ci/prow/e2e-gcp-common-templates-windows2016 52ee681 link true /test e2e-gcp-common-templates-windows2016
ci/prow/e2e-gcp-common-templates-windows11 52ee681 link true /test e2e-gcp-common-templates-windows11
ci/prow/e2e-gcp-common-templates-windows2022 52ee681 link true /test e2e-gcp-common-templates-windows2022
ci/prow/e2e-gcp-common-templates-windows2019 52ee681 link true /test e2e-gcp-common-templates-windows2019
ci/prow/e2e-gcp-common-templates-windows10 52ee681 link true /test e2e-gcp-common-templates-windows10

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

0xFelix
0xFelix approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
@ksimon1
Copy link
Member Author

ksimon1 commented Sep 10, 2024

Merging, the failing tests are not caused by this change

@ksimon1 ksimon1 merged commit 2e7f118 into kubevirt:master Sep 10, 2024
8 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@geetikakay geetikakay Awaiting requested review from geetikakay

@opokornyy opokornyy Awaiting requested review from opokornyy

Assignees

@0xFelix 0xFelix

Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ksimon1 @kubevirt-bot @0xFelix