-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: patterns in expect script and adjust timeout/exit conditions #635
base: master
Are you sure you want to change the base?
fix: patterns in expect script and adjust timeout/exit conditions #635
Conversation
Hi @nestoracunablanco. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/retest |
3 similar comments
/retest |
/retest |
/retest |
@ksimon1 @jcanocan I've been encountering this error frequently in the CI logs:
As far as I can tell, this issue is not related to my changes, as they only apply once the VM is ready. Are you experiencing any additional workload with your CI lately? |
The issue identified was that the string "1" is recognized as a pattern. The latest version of CentOS Stream 9 includes this "pattern" in its boot sequence. Signed-off-by: Nestor Acuna Blanco <nestor.acuna@ibm.com>
aa6f5da
to
f751b15
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@nestoracunablanco: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The issue identified was that the string "1" is recognized as a pattern. The latest version of CentOS Stream 9 includes this "pattern" in its boot sequence.
What this PR does / why we need it: s390x enablement
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: