Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing demos folder #308

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aburdenthehand
Copy link
Member

I intially created this folder after collecting some silent and notation-less demos for use at a KubeCon booth, and thought it would be useful to include them here along with the resulting transcript.

It was pointed out that this adds significant weight to any git clone or update. Our youtube (with notation or dub) or googledrive are better hosting platforms.

Release note:

NONE

Signed-off-by: Andrew Burden <aburden@redhat.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jul 9, 2024
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from aburdenthehand. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alicefr
Copy link
Member

alicefr commented Jul 10, 2024

@aburdenthehand can we upload the video on youtube and then simply share the link?

@aburdenthehand
Copy link
Member Author

@alicefr We can, but I think this particular demo is pretty dated by now. I think we would be better off recording an updated demo with either on-screen description wipes or voice commentary; the latter of which is preferable as it can generate subtitles, which can also be auto-translated by youtube for a broader audience.

@alicefr
Copy link
Member

alicefr commented Jul 10, 2024

@alicefr We can, but I think this particular demo is pretty dated by now. I think we would be better off recording an updated demo with either on-screen description wipes or voice commentary; the latter of which is preferable as it can generate subtitles, which can also be auto-translated by youtube for a broader audience.

Ok, make sense

Copy link
Member

@xpivarc xpivarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: it will still leave on in our git

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2024
@kubevirt-bot
Copy link

Pull requests that are marked with lgtm should receive a review
from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review

@kubevirt-bot kubevirt-bot added the needs-approver-review Indicates that a PR requires a review from an approver. label Sep 23, 2024
@jean-edouard
Copy link
Contributor

@aburdenthehand see the comment from @xpivarc, this PR won't solve the slow git checkout. Do you still think this PR makes sense?
Or do we maybe want to consider altering history to truly remove the files? (would that even do the trick?)

@aburdenthehand
Copy link
Member Author

Riiight, I'm with you. Great point. So this would only save people from navigating to a dead-end folder if they were looking for demos.
Looks like we can remove it from history: https://docs.github.com/en/repositories/working-with-files/managing-large-files/about-large-files-on-github#removing-a-file-that-was-added-in-an-earlier-commit
As this file represents 1/4 of the repo size, I am in favour of its removal from the forever times aka git history

@dankenigsberg
Copy link
Member

As every time traveler would tell, modifying history is a delicate business. If you decide to do so, make sure to keep an archive of the current repo prior to the change (e.g community-with-demo) so it can be verified that the filetree of the last commit in the old repo is exactly the same as that of the first commit of the new repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. needs-approver-review Indicates that a PR requires a review from an approver. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants