-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing demos folder #308
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Andrew Burden <aburden@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@aburdenthehand can we upload the video on youtube and then simply share the link? |
@alicefr We can, but I think this particular demo is pretty dated by now. I think we would be better off recording an updated demo with either on-screen description wipes or voice commentary; the latter of which is preferable as it can generate subtitles, which can also be auto-translated by youtube for a broader audience. |
Ok, make sense |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: it will still leave on in our git
Pull requests that are marked with After that period the bot marks them with the label /label needs-approver-review |
@aburdenthehand see the comment from @xpivarc, this PR won't solve the slow git checkout. Do you still think this PR makes sense? |
Riiight, I'm with you. Great point. So this would only save people from navigating to a dead-end folder if they were looking for demos. |
As every time traveler would tell, modifying history is a delicate business. If you decide to do so, make sure to keep an archive of the current repo prior to the change (e.g community-with-demo) so it can be verified that the filetree of the last commit in the old repo is exactly the same as that of the first commit of the new repo. |
I intially created this folder after collecting some silent and notation-less demos for use at a KubeCon booth, and thought it would be useful to include them here along with the resulting transcript.
It was pointed out that this adds significant weight to any git clone or update. Our youtube (with notation or dub) or googledrive are better hosting platforms.
Release note: