Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

design-proposal: rewrite node-labeller to be more modular and testable #322

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

design-proposal: rewrite node-labeller to be more modular and testable #322

wants to merge 1 commit into from
+90 −0

Commits on Sep 8, 2024

  1. node-labeller rewrite 

    The node-labeller has deviated from its primary purpose of simply labeling nodes. It now also handles inferring host capabilities for the vmcontroller, a task unrelated to its core function. Most of the capabilities it gathers aren't relevant to node labeling, leading to an overcomplicated design and unnecessary coupling with the vmcontroller which hinders testing and extensibility of both components.

As such this design proposal seeks to decouple the two and simplify
node-labeller to focus on its original intended purpose while moving
its current inference logic to a separate virt-handler unit.

Signed-off-by: Adi Aloni <adialoni101@gmail.com>
    @Acedus
    Acedus committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    673a190 View commit details
    Browse the repository at this point in the history