Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sigs,generate: improve validation, update sig-list generation #350

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Nov 6, 2024

What this PR does / why we need it:

This PR improves the validation of sigs.yaml - it checks entries with

  • existing directories (sig/wg)
  • existing labels (using project-infra labels.yaml)
  • whether github accounts are actually org members (using project-infra orgs.yaml)

If --dry-run flag is false it will overwrite the orgs.yaml with the result, where each entry that failed to check will have been removed.

Also it adds to make target generate the run of the validation with --dry-run=false which will lead to a modified sigs.yaml which in turn will update the sig-list.md with corrected entries, which will then fail the check whether all changes have been committed.

This effectively will automate the validation whether all changes are correct and have been applied to generated markdown.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #321

Special notes for your reviewer:

@kubevirt-bot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 6, 2024
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rmohr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 11, 2024
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2024
@dhiller
Copy link
Contributor Author

dhiller commented Nov 12, 2024

/test ?

@kubevirt-bot
Copy link

@dhiller: The following commands are available to trigger required jobs:

  • /test pull-community-make-generate
  • /test pull-community-validate-sigs-yaml

Use /test all to run the following jobs that were automatically triggered:

  • pull-community-make-generate

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dhiller
Copy link
Contributor Author

dhiller commented Nov 12, 2024

/rehearse ?

@dhiller
Copy link
Contributor Author

dhiller commented Nov 12, 2024

/test pull-community-make-generate

@dhiller
Copy link
Contributor Author

dhiller commented Nov 12, 2024

@dhiller: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-community-make-generate a519c22 link true /test pull-community-make-generate

Error makes sense, since we need to modify the presubmit to add the project-infra directory, so that the binary can access it.

@dhiller
Copy link
Contributor Author

dhiller commented Nov 13, 2024

/hold

since this PR requires an update of pull-community-make-generate - it needs the project-infra checkout to access labels.yaml and orgs.yaml as described in PR description.

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2024
@dhiller dhiller marked this pull request as ready for review November 13, 2024 10:15
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2024
@dhiller
Copy link
Contributor Author

dhiller commented Nov 14, 2024

pull-community-make-generate

Will be fixed by kubevirt/project-infra#3761

@dhiller
Copy link
Contributor Author

dhiller commented Nov 15, 2024

/test pull-community-make-generate

@dhiller
Copy link
Contributor Author

dhiller commented Nov 15, 2024

/unhold

should be ready to go in now.

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2024
Update validator code to take into account new sigs.yaml fields.
Add validation for chairs, leads, labels and directories.

Signed-off-by: Daniel Hiller <dhiller@redhat.com>
Signed-off-by: Daniel Hiller <dhiller@redhat.com>
Signed-off-by: Daniel Hiller <dhiller@redhat.com>
Signed-off-by: Daniel Hiller <dhiller@redhat.com>
Signed-off-by: Daniel Hiller <dhiller@redhat.com>
@kubevirt-bot
Copy link

@dhiller: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-community-validate-sigs-yaml 1f21b6d link true /test pull-community-validate-sigs-yaml
pull-community-make-generate 1f21b6d link true /test pull-community-make-generate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dhiller
Copy link
Contributor Author

dhiller commented Nov 15, 2024

/hold

to wait for kubevirt/project-infra#3762 to go in

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sig-list.md: create postsubmit prow job that updates after changes to sigs.yaml
2 participants