-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sigs,generate: improve validation, update sig-list generation #350
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ba24463
to
a519c22
Compare
/test ? |
@dhiller: The following commands are available to trigger required jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/rehearse ? |
/test pull-community-make-generate |
Error makes sense, since we need to modify the presubmit to add the project-infra directory, so that the binary can access it. |
/hold since this PR requires an update of |
Will be fixed by kubevirt/project-infra#3761 |
/test pull-community-make-generate |
/unhold should be ready to go in now. |
Update validator code to take into account new sigs.yaml fields. Add validation for chairs, leads, labels and directories. Signed-off-by: Daniel Hiller <dhiller@redhat.com>
Signed-off-by: Daniel Hiller <dhiller@redhat.com>
Signed-off-by: Daniel Hiller <dhiller@redhat.com>
Signed-off-by: Daniel Hiller <dhiller@redhat.com>
Signed-off-by: Daniel Hiller <dhiller@redhat.com>
a519c22
to
1f21b6d
Compare
@dhiller: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/hold to wait for kubevirt/project-infra#3762 to go in |
What this PR does / why we need it:
This PR improves the validation of
sigs.yaml
- it checks entries withIf
--dry-run
flag isfalse
it will overwrite the orgs.yaml with the result, where each entry that failed to check will have been removed.Also it adds to make target
generate
the run of the validation with--dry-run=false
which will lead to a modified sigs.yaml which in turn will update the sig-list.md with corrected entries, which will then fail the check whether all changes have been committed.This effectively will automate the validation whether all changes are correct and have been applied to generated markdown.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #321
Special notes for your reviewer: