Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.43] Remove tag from DataImportCron registry source URL #2101

Merged
merged 2 commits into from
Jan 18, 2022
Merged

[release-v1.43] Remove tag from DataImportCron registry source URL #2101

merged 2 commits into from
Jan 18, 2022

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #2086

/assign arnongilboa

NONE

@arnongilboa
Remove tag from DataImportCron registry source URL
e69346c 
There are cases when DataImportCron registry source URL contains tag
referring a specific version. We use this tagged URL when polling for
source updates, but on import we would like to remove the tag as we use
a specific sha256. E.g. for docker://quay.io/containerdisks/centos:8.4
the :8.4 tag will be removed.

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
@arnongilboa
Use Docker reference parsing
f77b6ba 
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 13, 2022
@kubevirt-bot kubevirt-bot mentioned this pull request Jan 13, 2022
Merged
@arnongilboa
Copy link
Collaborator

bz 2037270

@mhenriks
Copy link
Member

/retest

@mhenriks
Copy link
Member

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2022
@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2022
@brybacki
Copy link
Contributor

the CI was fixed by kubevirt/project-infra#1846
/retest

@awels
Copy link
Member

awels commented Jan 14, 2022

/test pull-containerized-data-importer-e2e-k8s-1.21-hpp

@arnongilboa
Copy link
Collaborator

/retest

@brybacki
Copy link
Contributor

/test pull-containerized-data-importer-e2e-k8s-1.21-hpp

  • test: 1899 2 DVs succeeded, on in progress. There was some slowness?

  • test: 3996 - prometheus fails, but the error message is not maningful (Expected : false to be true)
    @akalenyu might it be a new connection reset problem?

@akalenyu
Copy link
Collaborator

/test pull-containerized-data-importer-e2e-k8s-1.21-hpp

  • test: 1899 2 DVs succeeded, on in progress. There was some slowness?
  • test: 3996 - prometheus fails, but the error message is not maningful (Expected : false to be true)
    @akalenyu might it be a new connection reset problem?

Yep that would be it

@awels
Copy link
Member

awels commented Jan 17, 2022

/override pull-containerized-data-importer-e2e-k8s-1.21-hpp

@kubevirt-bot
Copy link
Contributor Author

@awels: Overrode contexts on behalf of awels: pull-containerized-data-importer-e2e-k8s-1.21-hpp

In response to this:

/override pull-containerized-data-importer-e2e-k8s-1.21-hpp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@arnongilboa
Copy link
Collaborator

/retest

@awels
Copy link
Member

awels commented Jan 17, 2022

/override pull-containerized-data-importer-e2e-k8s-1.21-ceph

@kubevirt-bot
Copy link
Contributor Author

@awels: Overrode contexts on behalf of awels: pull-containerized-data-importer-e2e-k8s-1.21-ceph

In response to this:

/override pull-containerized-data-importer-e2e-k8s-1.21-ceph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@arnongilboa
Copy link
Collaborator

/retest

@awels
Copy link
Member

awels commented Jan 18, 2022

/override pull-containerized-data-importer-e2e-k8s-1.21-ceph

@kubevirt-bot
Copy link
Contributor Author

@awels: Overrode contexts on behalf of awels: pull-containerized-data-importer-e2e-k8s-1.21-ceph

In response to this:

/override pull-containerized-data-importer-e2e-k8s-1.21-ceph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit 68c665c into kubevirt:release-v1.43 Jan 18, 2022
@arnongilboa
Copy link
Collaborator

bz 2037270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awels awels Awaiting requested review from awels

@maya-r maya-r Awaiting requested review from maya-r

Assignees

@mhenriks mhenriks

@arnongilboa arnongilboa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kubevirt-bot @arnongilboa @mhenriks @brybacki @awels @akalenyu