[release-v1.43] Do not factor fs overhead into available space during validation #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This image size and filesystem overhead combination was experimentally determined to reproduce bz#2064936 in CI when using ceph/rbd with a Filesystem mode PV since the filesystem capacity will be constrained by the PVC request size. Below is the problem it tries to recreate: When validating whether an image will fit into a PV we compare the image's virtual size to the filesystem's reported available space to guage whether it will fit. The current calculation reduces the apparent available space by the configured filesystem overhead value but the overhead is already (mostly) factored into the result of Statfs. This causes the check to fail for PVCs that are just large enough to accommodate an image plus overhead (ie. when using the DataVolume Storage API with filesystem PVs with capacity constrained by the PVC storage request size). This was not caught in testing because HPP does not have capacity constrained PVs and we are typically testing block volumes in the ceph lanes. It can be triggered in our CI by allocating a Filesystem PV on ceph-rbd storage because these volumes are capacity constrained and subject to filesystem overhead. Signed-off-by: Bartosz Rybacki <brybacki@redhat.com>
Corrects the validation logic for target volume. Below description of the original problem: When validating whether an image will fit into a PV we compare the image's virtual size to the filesystem's reported available space to guage whether it will fit. The current calculation reduces the apparent available space by the configured filesystem overhead value but the overhead is already (mostly) factored into the result of Statfs. This causes the check to fail for PVCs that are just large enough to accommodate an image plus overhead (ie. when using the DataVolume Storage API with filesystem PVs with capacity constrained by the PVC storage request size). This was not caught in testing because HPP does not have capacity constrained PVs and we are typically testing block volumes in the ceph lanes. It can be triggered in our CI by allocating a Filesystem PV on ceph-rbd storage because these volumes are capacity constrained and subject to filesystem overhead. Signed-off-by: Bartosz Rybacki <brybacki@redhat.com>
Removed redundant and misleading part about pvc size and update the simplification Signed-off-by: Bartosz Rybacki <brybacki@redhat.com>
The test checks that the validation logic takes fs Overhead into account. New validation logic does not check fs overhead. So test is no longer relevant. Signed-off-by: Bartosz Rybacki <brybacki@redhat.com>
kubevirt-bot
added
the
release-note
kubevirt-bot
added
the
dco-signoff: yes
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2195
/assign awels