Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose all CDI CRDs to cluster-readers #2245

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

arnongilboa
Copy link
Collaborator

What this PR does / why we need it:

Add get/list/watch cluster RBAC to:

  • cdiconfigs.cdi.kubevirt.io
  • dataimportcrons.cdi.kubevirt.io
  • datasources.cdi.kubevirt.io
  • objecttransfers.cdi.kubevirt.io
  • storageprofiles.cdi.kubevirt.io

Signed-off-by: Arnon Gilboa agilboa@redhat.com

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Expose all CDI CRDs to cluster-readers

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 24, 2022
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
@awels
Copy link
Member

awels commented Apr 25, 2022

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2022
@kubevirt-bot kubevirt-bot merged commit 6e9891f into kubevirt:main Apr 25, 2022
@arnongilboa
Copy link
Collaborator Author

/cherrypick release-v1.43

@kubevirt-bot
Copy link
Contributor

@arnongilboa: #2245 failed to apply on top of branch "release-v1.43":

Applying: Expose all CDI CRDs to cluster-readers
Using index info to reconstruct a base tree...
M	cmd/cdi-cloner/BUILD.bazel
M	pkg/controller/BUILD.bazel
M	pkg/importer/BUILD.bazel
M	pkg/operator/controller/BUILD.bazel
A	tools/metricsdocs/BUILD.bazel
Falling back to patching base and 3-way merge...
Auto-merging tools/cdi-containerimage-server/BUILD.bazel
CONFLICT (content): Merge conflict in tools/cdi-containerimage-server/BUILD.bazel
Auto-merging pkg/operator/controller/BUILD.bazel
Auto-merging pkg/importer/BUILD.bazel
Auto-merging pkg/controller/BUILD.bazel
Auto-merging cmd/cdi-cloner/BUILD.bazel
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Expose all CDI CRDs to cluster-readers
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-v1.43

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

arnongilboa added a commit to arnongilboa/containerized-data-importer that referenced this pull request Apr 25, 2022
Manual backport of kubevirt#2245

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request Apr 26, 2022
Manual backport of #2245

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants