Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment versions of k8s used in CI #2278

Merged
merged 2 commits into from
May 19, 2022

Conversation

awels
Copy link
Member

@awels awels commented May 16, 2022

Signed-off-by: Alexander Wels awels@redhat.com

What this PR does / why we need it:
Instead of 1.21 and 1.22, now use 1.22 and 1.23

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 16, 2022
@akalenyu
Copy link
Collaborator

akalenyu commented May 16, 2022

Wouldn't we have to switch to 1.24 just in a bit?

@awels
Copy link
Member Author

awels commented May 16, 2022

Well not sure when 1.24 becomes available in kubevirtci, also we can decide if that is something we want to do or not at any time.

@akalenyu
Copy link
Collaborator

akalenyu commented May 17, 2022

Well not sure when 1.24 becomes available in kubevirtci, also we can decide if that is something we want to do or not at any time.

Gotcha, right
BTW on k8s > 1.22 rook will fail to deploy the CSIDriver object and this possibly explains the failures, more detail in:
kubevirt/kubevirtci#794

This uncovered some related nils on looking up csidrivers:
#2253

@awels
Copy link
Member Author

awels commented May 17, 2022

Yeah there seems to be a problem with kubevirt/kubevirtci#794 with some of the tests.

@akalenyu
Copy link
Collaborator

@awels ceph bump merged in kubevirtci, would you like to bump it here or new PR?

@awels
Copy link
Member Author

awels commented May 19, 2022

I was waiting for that to merge, going to bump it here

awels added 2 commits May 19, 2022 07:50
Take advantage of newer versions of k8s for testing.

Signed-off-by: Alexander Wels <awels@redhat.com>
Signed-off-by: Alexander Wels <awels@redhat.com>
@akalenyu
Copy link
Collaborator

/test pull-containerized-data-importer-e2e-hpp-latest
#1988

@akalenyu
Copy link
Collaborator

I was waiting for that to merge, going to bump it here

I'll double-check number of tests ran on ceph lane vs older version to make sure we're not skipping everything lol

@awels
Copy link
Member Author

awels commented May 19, 2022

/test pull-containerized-data-importer-e2e-nfs
/test pull-containerized-data-importer-e2e-upg

@akalenyu
Copy link
Collaborator

Same exact amount of ceph tests as before
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2022
@awels
Copy link
Member Author

awels commented May 19, 2022

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2022
@kubevirt-bot kubevirt-bot merged commit 6366ef3 into kubevirt:main May 19, 2022
@akalenyu
Copy link
Collaborator

@awels should we cherry pick to 49?

@awels
Copy link
Member Author

awels commented May 24, 2022

Yeah since we want 1.49 to support k8s 1.23 at a minimum.
/cherrypick release-v1.49

@kubevirt-bot
Copy link
Contributor

@awels: new pull request created: #2293

In response to this:

Yeah since we want 1.49 to support k8s 1.23 at a minimum.
/cherrypick release-v1.49

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants