Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.43] Fix smart clone request size update #2281

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #2276

/assign ShellyKa13

Fix smart clone not updating request size if already got the requested size so expansion is not required

In case the pvc got an actual size as the expected
size there wasn't an update of the pvc spec with the
actual user request size, which left the pvc spec with
a smaller size then the user requested(the data size).
This caused a discrepancy when trying to restore such pvc,
which restored a pvc with the small size instead of the user request
size.

Signed-off-by: Shelly Kagan <skagan@redhat.com>
Signed-off-by: Shelly Kagan <skagan@redhat.com>
@kubevirt-bot kubevirt-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 19, 2022
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label May 19, 2022
@kubevirt-bot kubevirt-bot requested a review from aglitke May 19, 2022 08:50
@awels
Copy link
Member

awels commented May 19, 2022

/test pull-cdi-unit-test
/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2022
@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2022
@kubevirt-bot
Copy link
Contributor Author

@kubevirt-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdi-unit-test 98d4f8f link false /test pull-cdi-unit-test
pull-containerized-data-importer-e2e-ceph 98d4f8f link unknown /test pull-containerized-data-importer-e2e-ceph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@brybacki
Copy link
Contributor

unit test has problems with image?

@ShellyKa13
Copy link
Contributor

unit test has problems with image?

pkg/controller/datavolume-controller_test.go:1406:43: too many arguments in call to createStorageClassWithProvisioner
in the new UT I added. need to fix manually..

@ShellyKa13
Copy link
Contributor

/close
closing due to open of a manual cherry pick

@kubevirt-bot
Copy link
Contributor Author

@ShellyKa13: Closed this PR.

In response to this:

/close
closing due to open of a manual cherry pick

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants