-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v1.43] Fix smart clone request size update #2281
[release-v1.43] Fix smart clone request size update #2281
Conversation
In case the pvc got an actual size as the expected size there wasn't an update of the pvc spec with the actual user request size, which left the pvc spec with a smaller size then the user requested(the data size). This caused a discrepancy when trying to restore such pvc, which restored a pvc with the small size instead of the user request size. Signed-off-by: Shelly Kagan <skagan@redhat.com>
Signed-off-by: Shelly Kagan <skagan@redhat.com>
/test pull-cdi-unit-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@kubevirt-bot: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
unit test has problems with |
pkg/controller/datavolume-controller_test.go:1406:43: too many arguments in call to createStorageClassWithProvisioner |
/close |
@ShellyKa13: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #2276
/assign ShellyKa13