Add omitempty to DataSourceStatus.source #2382
Conversation
kubevirt-bot
added
release-note-none
|
Whoops should have had that in the original PR. |
|
maybe add the PR description to the commmit msg |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Making this new status field required in the JSON breaks API backward compatibility, so omitempty is added. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa
force-pushed
the
das_status_source_omitempty
branch
from
d8655e4
to
f053ba9
Compare
|
/lgtm |
|
can a new release be created please ? |
|
/cherrypick release-v1.53 |
|
@akalenyu: new pull request created: #2398 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Arnon Gilboa agilboa@redhat.com
What this PR does / why we need it:
Making this new status field required in the JSON, breaks API backward compatibility, so omitempty is added.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: