Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.53] Manual backport of 2364, 2375 #2401

Merged
merged 2 commits into from
Aug 17, 2022
Merged

[release-v1.53] Manual backport of 2364, 2375 #2401

merged 2 commits into from
Aug 17, 2022

Conversation

akalenyu
Copy link
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Status reporting for CSI & Smart clones with WFFC storage
Fix clone datavolume with populated target PVC without source

akalenyu and others added 2 commits August 17, 2022 17:24
@akalenyu
Status reporting for CSI & Smart clones with WFFC storage (kubevirt#2364
d82fc70 
)

* Fix logging level so we respect it in controllers/operator

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>

* Fix CSI & Smart clones with WFFC storage status reporting

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
@ShellyKa13 @akalenyu
Check for pvc populated before doing any clone validations and actions (
f0e866c 
kubevirt#2375)

In case our pvc is already populated no need to check for source PVC
unknown size etc.

Signed-off-by: Shelly Kagan <skagan@redhat.com>

Signed-off-by: Shelly Kagan <skagan@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 17, 2022
@akalenyu akalenyu mentioned this pull request Aug 17, 2022
Closed
@awels
Copy link
Member

awels commented Aug 17, 2022

/lgtm
/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 17, 2022
ShellyKa13
ShellyKa13 reviewed Aug 17, 2022
View reviewed changes
Copy link
Contributor

@ShellyKa13 ShellyKa13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm

@awels
Copy link
Member

awels commented Aug 17, 2022

/override pull-containerized-data-importer-e2e-ceph

@kubevirt-bot
Copy link
Contributor

@awels: Overrode contexts on behalf of awels: pull-containerized-data-importer-e2e-ceph

In response to this:

/override pull-containerized-data-importer-e2e-ceph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit c8f06b4 into kubevirt:release-v1.53 Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShellyKa13 ShellyKa13 ShellyKa13 left review comments

@awels awels Awaiting requested review from awels

@maya-r maya-r Awaiting requested review from maya-r

Assignees

@awels awels

@ShellyKa13 ShellyKa13

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akalenyu @awels @kubevirt-bot @ShellyKa13