-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v1.49] Manual fix for clone without source pvc but target pvc already populated #2406
[release-v1.49] Manual fix for clone without source pvc but target pvc already populated #2406
Conversation
Signed-off-by: Shelly Kagan <skagan@redhat.com>
3895f3c
to
577b6fa
Compare
In case the target pvc exists and populated we should allow the clone to complete successfully without doing anything. Adjust the code and add a test for that case. Signed-off-by: Shelly Kagan <skagan@redhat.com>
577b6fa
to
b7cf62e
Compare
/hold |
@ShellyKa13 I think you need to coordinnate your change with @alromeros. If #2366 is merged, then your change could be smaller and simpler. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/unhold |
What this PR does / why we need it:
This PR takes part of PR: #2306
and PR: #2375
to fix this issue with minimal changes.
In case the target pvc exists and populated we should allow the clone to complete successfully without doing anything
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes # BZ #2109407
https://bugzilla.redhat.com/show_bug.cgi?id=2109407
Special notes for your reviewer:
Release note: