Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.43] Redo 2405 #2412

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Conversation

mhenriks
Copy link
Member

…vc but target pvc already populated (#2405)""

This reverts commit 4e20397.

Signed-off-by: Michael Henriksen mhenriks@redhat.com

What this PR does / why we need it:

This PR is a redo -f #2405 because I mistakenly merged it before I should have

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

BZ #2109406
https://bugzilla.redhat.com/show_bug.cgi?id=2109406

Special notes for your reviewer:

Release note:

Fix for clone without source pvc but target pvc already populated

…vc but target pvc already populated (kubevirt#2405)""

This reverts commit 4e20397.

Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 25, 2022
@mhenriks
Copy link
Member Author

/hold
/approve

@kubevirt-bot kubevirt-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L labels Aug 25, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2022
@mhenriks
Copy link
Member Author

/retest

@brybacki
Copy link
Contributor

Looking at this now, again I can see that the actual cherry pick of 2306 already waits in the queue (for review/approval), and this PR combines parts of #2306 with a PR: #2375.

Here is that other cherry pick:
[release-v1.43] Manual backport of 'Allow creating clones without source PVC (#2306)' #2367
#2367

So merging this will make merging 2367 harder. What is our plan, the priorities for merging this one and 2367.

@brybacki
Copy link
Contributor

@ShellyKa13 I think you need to coordinate with @alromeros on this change and the #2367

@brybacki
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2022
@ShellyKa13
Copy link
Contributor

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2022
@kubevirt-bot kubevirt-bot merged commit 8efc6dd into kubevirt:release-v1.43 Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants