-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add http zstd reader for cdi #2593
Conversation
Hi @huangzynn. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Hi, thanks for the PR, I would like to ask if you could add some functional tests to demonstrate the feature working. We deploy an http server in our CI that automatically generates a variety of formats that are then used in our tests. If you look at https://github.com/kubevirt/containerized-data-importer/blob/main/tools/cdi-func-test-file-host-init/main.go#L43-L53 it provides a list of different formats that need to be generated. The actual code that generates the different formats can be found here https://github.com/kubevirt/containerized-data-importer/blob/main/tests/utils/fileConversion.go If you have issues with any of that feel free to contact me here or on slack, and I can walk you through it. Other than that, it looks good and I have no doubt it works, I just want to be able to prove it to other people that ask. |
Also to sign your commits, you can do a |
/retest |
16c16ad
to
4407d10
Compare
Signed-off-by: huangzy <huangzynn@outlook.com>
/retest |
Almost there, one more thing, if you look at https://github.com/kubevirt/containerized-data-importer/blob/main/tests/datavolume_test.go#L579-L602 you will see it build a DataVolume that imports a plain qcow2 file. If you could add another entry that imports the .zstd file you created in the http server, so we can verify the entire flow works. All you have to do is modify the name to lets say |
Signed-off-by: huangzy <huangzynn@outlook.com>
So the test looks good, but it is failing because the http server doesn't contain the file we are looking for (the importer pod is returning a 404). Let me grab the PR and I can see what exactly is being generated when the http server starts. It is likely just a file name that needs to change or we don't generate for tiny core. |
Signed-off-by: huangzy <huangzynn@outlook.com>
Sorry, this is my code error. |
/retest |
Still the same 404, hopefully I will have some time today to take a look |
It was so silly, apparently the generated file name is
|
Thank you for your help |
Signed-off-by: huangzy <huangzynn@outlook.com>
/retest |
1 similar comment
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
add http zstd reader for cdi