Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IBM CSI to known provisioners #2762

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

arnongilboa
Copy link
Collaborator

@arnongilboa arnongilboa commented Jun 20, 2023

What this PR does / why we need it:
Add StorageProfile default ClaimPropertySets (StorageCapabilities) for the provisioners.

Release note:

Add IBM CSI to known provisioners

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 20, 2023
@arnongilboa arnongilboa changed the title [WIP] Add IBM Fusion CSI to known provisioners [WIP] Add IBM CSI to known provisioners Jun 20, 2023
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
@arnongilboa arnongilboa changed the title [WIP] Add IBM CSI to known provisioners Add IBM CSI to known provisioners Jun 26, 2023
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2023
@aglitke
Copy link
Member

aglitke commented Jun 26, 2023

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
@akalenyu
Copy link
Collaborator

/test pull-containerized-data-importer-e2e-istio
/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@arnongilboa
Copy link
Collaborator Author

/retest

@kubevirt-bot kubevirt-bot merged commit ff8c016 into kubevirt:main Jun 27, 2023
@arnongilboa
Copy link
Collaborator Author

arnongilboa commented Jun 28, 2023

/cherrypick release-v1.57

@kubevirt-bot
Copy link
Contributor

@arnongilboa: new pull request created: #2779

In response to this:

/cherrypick release-v1.57
/cherrypick release-v1.56
/cherrypick release-v1.55

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@arnongilboa
Copy link
Collaborator Author

/cherrypick release-v1.56

@kubevirt-bot
Copy link
Contributor

@arnongilboa: #2762 failed to apply on top of branch "release-v1.56":

Applying: Add IBM CSI to known provisioners
Using index info to reconstruct a base tree...
M	pkg/storagecapabilities/storagecapabilities.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/storagecapabilities/storagecapabilities.go
CONFLICT (content): Merge conflict in pkg/storagecapabilities/storagecapabilities.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add IBM CSI to known provisioners
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-v1.56

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

arnongilboa added a commit to arnongilboa/containerized-data-importer that referenced this pull request Jul 6, 2023
Manual backport of kubevirt#2762 kubevirt#2771

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa added a commit to arnongilboa/containerized-data-importer that referenced this pull request Jul 6, 2023
Manual backport of kubevirt#2762 kubevirt#2771

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request Jul 6, 2023
Manual backport of #2762 #2771

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request Jul 6, 2023
Manual backport of #2762 #2771

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants