-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow up for GC=on in some tests #2784
Conversation
This may be the reason for the flakes we're seeing: https://storage.googleapis.com/kubevirt-prow/pr-logs/pull/kubevirt_containerized-data-importer/2774/pull-containerized-data-importer-e2e-hpp-latest/1675408112015642624/artifacts/1_pvs.log With GC on we may want to delete the DV. We may have more cases like this one scattered around, so let's keep an eye Not sure how populators DVs handle that situation but we see that the test PV is simply gone from artifacts Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
Skipping CI for Draft Pull Request. |
/test all |
/test all |
1 similar comment
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cc @awels |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-v1.57 |
@akalenyu: new pull request created: #2810 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This may be the reason for the flakes we're seeing: https://search.ci.kubevirt.io/?search=9924&maxAge=336h&context=1&type=bug%2Bissue%2Bjunit&name=containerized-data-importer&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job
With GC on we want to delete the DV (PVC won't cut it)
We may have more cases like this one scattered around, so let's keep an eye
Not sure how populators DVs handle that situation but we see that the test PV is simply gone from artifacts
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: