Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up for GC=on in some tests #2784

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

akalenyu
Copy link
Collaborator

@akalenyu akalenyu commented Jul 2, 2023

What this PR does / why we need it:
This may be the reason for the flakes we're seeing: https://search.ci.kubevirt.io/?search=9924&maxAge=336h&context=1&type=bug%2Bissue%2Bjunit&name=containerized-data-importer&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job

With GC on we want to delete the DV (PVC won't cut it)
We may have more cases like this one scattered around, so let's keep an eye

Not sure how populators DVs handle that situation but we see that the test PV is simply gone from artifacts

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

This may be the reason for the flakes we're seeing:
https://storage.googleapis.com/kubevirt-prow/pr-logs/pull/kubevirt_containerized-data-importer/2774/pull-containerized-data-importer-e2e-hpp-latest/1675408112015642624/artifacts/1_pvs.log

With GC on we may want to delete the DV.
We may have more cases like this one scattered around, so let's keep an eye

Not sure how populators DVs handle that situation but we see
that the test PV is simply gone from artifacts

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 2, 2023
@akalenyu
Copy link
Collaborator Author

akalenyu commented Jul 2, 2023

/test all

@akalenyu
Copy link
Collaborator Author

akalenyu commented Jul 2, 2023

/test all

1 similar comment
@akalenyu
Copy link
Collaborator Author

akalenyu commented Jul 3, 2023

/test all

@akalenyu akalenyu marked this pull request as ready for review July 3, 2023 13:27
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2023
Copy link
Contributor

@ShellyKa13 ShellyKa13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2023
@akalenyu
Copy link
Collaborator Author

/cc @awels

@kubevirt-bot kubevirt-bot requested a review from awels July 10, 2023 11:55
@arnongilboa
Copy link
Collaborator

/retest

@awels
Copy link
Member

awels commented Jul 14, 2023

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2023
@kubevirt-bot kubevirt-bot merged commit 5eb4622 into kubevirt:main Jul 14, 2023
@akalenyu
Copy link
Collaborator Author

/cherrypick release-v1.57

@kubevirt-bot
Copy link
Contributor

@akalenyu: new pull request created: #2810

In response to this:

/cherrypick release-v1.57

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants