Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support raw.tar.gz files #2822

Closed
wants to merge 2 commits into from
Closed

Conversation

a180285
Copy link

@a180285 a180285 commented Jul 27, 2023

What this PR does / why we need it:

When I try to import xxx.raw.tar.gz it will failed.
And only do ungzip but not untar

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Support import xxx.raw.tar.gz files

@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 27, 2023
@kubevirt-bot
Copy link
Contributor

Hi @a180285. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign akalenyu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 28, 2023
root added 2 commits July 28, 2023 02:43
Signed-off-by: HuangWei <huangwei.a180285@gmail.com>
Signed-off-by: HuangWei <huangwei.a180285@gmail.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jul 28, 2023
@a180285
Copy link
Author

a180285 commented Jul 29, 2023

@alromeros Can you help give some comment on this PR?

@alromeros
Copy link
Collaborator

Hey @a180285! I see we already have an open PR that's aiming to implement tar imports (#2748), so it might conflict with yours. The discussion there also implies that tar imports might not be as straightforward to implement, so I'd suggest reviewing it or proposing ideas/suggestions that you might have there.

Thanks for your contribution!

@a180285
Copy link
Author

a180285 commented Jul 29, 2023

Thanks, I see. Before that, I can use my changed version. Hope that PR can be merged soon.

@a180285 a180285 closed this Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants