-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump k8s.io/client-go dep for discovery client fixes #2855
bump k8s.io/client-go dep for discovery client fixes #2855
Conversation
k8s.io/client-go [v0.26.0, v0.26.3) was impacted by a regression in discovery client behavior kubernetes/kubernetes#118361 (comment) for details We are probably not hitting this due to not testing 1.27 upstream yet, or don't have the custom metric endpoints that send these nils in the response. (Reproduces on OpenShift ECs for example) Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
/test pull-cdi-linter |
/lgtm |
@awels: once the present PR merges, I will cherry-pick it on top of release-v1.57 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@awels: #2855 failed to apply on top of branch "release-v1.57":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* bump k8s.io/client-go dep for discovery client fixes k8s.io/client-go [v0.26.0, v0.26.3) was impacted by a regression in discovery client behavior kubernetes/kubernetes#118361 (comment) for details We are probably not hitting this due to not testing 1.27 upstream yet, or don't have the custom metric endpoints that send these nils in the response. (Reproduces on OpenShift ECs for example) Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> * make generate Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> --------- Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
* bump k8s.io/client-go dep for discovery client fixes k8s.io/client-go [v0.26.0, v0.26.3) was impacted by a regression in discovery client behavior kubernetes/kubernetes#118361 (comment) for details We are probably not hitting this due to not testing 1.27 upstream yet, or don't have the custom metric endpoints that send these nils in the response. (Reproduces on OpenShift ECs for example) Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> * make generate Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> --------- Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
* bump k8s.io/client-go dep for discovery client fixes k8s.io/client-go [v0.26.0, v0.26.3) was impacted by a regression in discovery client behavior kubernetes/kubernetes#118361 (comment) for details We are probably not hitting this due to not testing 1.27 upstream yet, or don't have the custom metric endpoints that send these nils in the response. (Reproduces on OpenShift ECs for example) * make generate --------- Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
What this PR does / why we need it:
k8s.io/client-go [v0.26.0, v0.26.3) was impacted by a regression in discovery client behavior,
see this issue for details.
We are probably not hitting this due to not testing 1.27 upstream yet, or don't have the custom metric endpoints that send these nils in the response. (Reproduces on OpenShift ECs for example)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: