Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump k8s.io/client-go dep for discovery client fixes #2855

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

akalenyu
Copy link
Collaborator

What this PR does / why we need it:
k8s.io/client-go [v0.26.0, v0.26.3) was impacted by a regression in discovery client behavior,
see this issue for details.
We are probably not hitting this due to not testing 1.27 upstream yet, or don't have the custom metric endpoints that send these nils in the response. (Reproduces on OpenShift ECs for example)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

BugFix: panic in /go/pkg/mod/k8s.io/client-go@v0.26.2/discovery/aggregated_discovery.go:88

k8s.io/client-go [v0.26.0, v0.26.3) was impacted by a regression in discovery client behavior
kubernetes/kubernetes#118361 (comment) for details
We are probably not hitting this due to not testing 1.27 upstream yet,
or don't have the custom metric endpoints that send these nils in the response.
(Reproduces on OpenShift ECs for example)

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 21, 2023
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
@akalenyu
Copy link
Collaborator Author

/test pull-cdi-linter

@awels
Copy link
Member

awels commented Aug 22, 2023

/lgtm
/approve
/cherrypick release-v1.57

@kubevirt-bot
Copy link
Contributor

@awels: once the present PR merges, I will cherry-pick it on top of release-v1.57 in a new PR and assign it to you.

In response to this:

/lgtm
/approve
/cherrypick release-v1.57

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2023
@kubevirt-bot kubevirt-bot merged commit edd6940 into kubevirt:main Aug 23, 2023
1 check passed
@kubevirt-bot
Copy link
Contributor

@awels: #2855 failed to apply on top of branch "release-v1.57":

Applying: bump k8s.io/client-go dep for discovery client fixes
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 bump k8s.io/client-go dep for discovery client fixes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/lgtm
/approve
/cherrypick release-v1.57

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

akalenyu added a commit to akalenyu/containerized-data-importer that referenced this pull request Aug 23, 2023
* bump k8s.io/client-go dep for discovery client fixes

k8s.io/client-go [v0.26.0, v0.26.3) was impacted by a regression in discovery client behavior
kubernetes/kubernetes#118361 (comment) for details
We are probably not hitting this due to not testing 1.27 upstream yet,
or don't have the custom metric endpoints that send these nils in the response.
(Reproduces on OpenShift ECs for example)

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>

* make generate

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>

---------

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
akalenyu added a commit to akalenyu/containerized-data-importer that referenced this pull request Aug 23, 2023
* bump k8s.io/client-go dep for discovery client fixes

k8s.io/client-go [v0.26.0, v0.26.3) was impacted by a regression in discovery client behavior
kubernetes/kubernetes#118361 (comment) for details
We are probably not hitting this due to not testing 1.27 upstream yet,
or don't have the custom metric endpoints that send these nils in the response.
(Reproduces on OpenShift ECs for example)

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>

* make generate

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>

---------

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request Aug 23, 2023
* bump k8s.io/client-go dep for discovery client fixes

k8s.io/client-go [v0.26.0, v0.26.3) was impacted by a regression in discovery client behavior
kubernetes/kubernetes#118361 (comment) for details
We are probably not hitting this due to not testing 1.27 upstream yet,
or don't have the custom metric endpoints that send these nils in the response.
(Reproduces on OpenShift ECs for example)



* make generate



---------

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants