Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update builder to use golang 1.20.10 and bazel 5.4.0 #2934

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

awels
Copy link
Member

@awels awels commented Oct 20, 2023

What this PR does / why we need it:
Update the builder to golang 1.20.10 and bazel 5.4.0

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Updated to bazel 5.4.0 and golang 1.20.10

Signed-off-by: Alexander Wels <awels@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Oct 20, 2023
@mhenriks
Copy link
Member

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023
@kubevirt-bot kubevirt-bot merged commit 20cced8 into kubevirt:main Oct 20, 2023
18 checks passed
@awels
Copy link
Member Author

awels commented Oct 26, 2023

/cherrypick release-v1.57

@kubevirt-bot
Copy link
Contributor

@awels: #2934 failed to apply on top of branch "release-v1.57":

Applying: Update builder to use golang 1.20.10 and bazel 5.4.0
Using index info to reconstruct a base tree...
M	hack/build/docker/builder/Dockerfile
Falling back to patching base and 3-way merge...
Auto-merging hack/build/docker/builder/Dockerfile
CONFLICT (content): Merge conflict in hack/build/docker/builder/Dockerfile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update builder to use golang 1.20.10 and bazel 5.4.0
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-v1.57

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awels
Copy link
Member Author

awels commented Oct 27, 2023

/cherrypick release-v1.57

@kubevirt-bot
Copy link
Contributor

@awels: new pull request created: #2946

In response to this:

/cherrypick release-v1.57

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants