Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.58] Add new Prometheus alerts and label existing alerts #3040

Merged
merged 1 commit into from
Dec 26, 2023
Merged

[release-v1.58] Add new Prometheus alerts and label existing alerts #3040

merged 1 commit into from
Dec 26, 2023

Conversation

arnongilboa
Copy link
Collaborator

@arnongilboa arnongilboa commented Dec 25, 2023 •
edited
Loading

What this PR does / why we need it:

Manual backport of #2998 & #3038

  • CDINoDefaultStorageClass - not having a default (or virt default) SC is surely not an OpenShift error, as admins may prefer their cluster users to only use explicit SC names. However, in the CDI context when DV is created with default SC but default does not exist, we will fire an error event and the PVC will be Pending for the default SC, so when there are such Pending PVCs we will fire an alert.

  • CDIDefaultStorageClassDegraded - when the default (or virt default) SC does not support CSI/Snapshot clone (smart clone) or does not have ReadWriteMany access mode (for live migration).

  • CDIStorageProfilesIncomplete - add storageClass and provisioner labels.

  • CDIDataImportCronOutdated - add dataImportCron namespace and name labels.

Also:

  • Rename the metric kubevirt_cdi_storageprofile_status to kubevirt_cdi_storageprofile_info since it always reports value 1, where the label values provide the details about the storage class and storage profile.
  • Add snapshot manifests for tests and deploy snapshot CRDs in the hpp destructive lane

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes CNV-36773

Special notes for your reviewer:

Release note:

Add Prometheus alerts CDINoDefaultStorageClass and CDIDefaultStorageClassDegraded; add informative labels to existing alerts CDIStorageProfilesIncomplete and CDIDataImportCronOutdated

@arnongilboa
[release-v1.58] Add new Prometheus alerts and label existing alerts
b1a295e 
Manual backport of kubevirt#2998 & kubevirt#3038

- CDINoDefaultStorageClass - not having a default (or virt default)
SC is surely not an OpenShift error, as admins may prefer their cluster
users to only use explicit SC names. However, in the CDI context when
DV is created with default SC but default does not exist, we will fire
an error event and the PVC will be Pending for the default SC, so when
there are such Pending PVCs we will fire an alert.

- CDIDefaultStorageClassDegraded - when the default (or virt default)
SC does not support CSI/Snapshot clone (smart clone) or does not have
ReadWriteMany access mode (for live migration).

- CDIStorageProfilesIncomplete - add storageClass and provisioner
labels.

- CDIDataImportCronOutdated - add dataImportCron namespace and name
labels.

Also:
* Rename the metric kubevirt_cdi_storageprofile_status to
kubevirt_cdi_storageprofile_info since it always reports value 1,
where the label values provide the details about the storage class and
storage profile.
* Add snapshot manifests for tests and deploy snapshot CRDs in the hpp
destructive lane

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XXL labels Dec 25, 2023
@akalenyu
Copy link
Collaborator

/test pull-containerized-data-importer-e2e-destructive

@kubevirt-bot
Copy link
Contributor

@akalenyu: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-containerized-data-importer-e2e-ceph
  • /test pull-containerized-data-importer-e2e-hpp-previous

The following commands are available to trigger optional jobs:

  • /test pull-cdi-apidocs
  • /test pull-cdi-generate-verify
  • /test pull-cdi-linter
  • /test pull-cdi-unit-test
  • /test pull-cdi-verify-go-mod

Use /test all to run all jobs.

In response to this:

/test pull-containerized-data-importer-e2e-destructive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

akalenyu
akalenyu reviewed Dec 25, 2023
View reviewed changes
Copy link
Collaborator

@akalenyu akalenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clean backport right? the only reason it's manual is to aggregate the two PRs?

@arnongilboa
Copy link
Collaborator Author

This is a clean backport right? the only reason it's manual is to aggregate the two PRs?

yep, and fix one line conflict of the CDIMultipleDefaultVirtStorageClasses tests_id :)

@ShellyKa13
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 25, 2023
@akalenyu
Copy link
Collaborator

/approve
https://issues.redhat.com/browse/CNV-36773

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 26, 2023
@kubevirt-bot kubevirt-bot merged commit 10bb5e6 into kubevirt:release-v1.58 Dec 26, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akalenyu akalenyu akalenyu left review comments

@maya-r maya-r Awaiting requested review from maya-r

@ShellyKa13 ShellyKa13 Awaiting requested review from ShellyKa13

Assignees

@ShellyKa13 ShellyKa13

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arnongilboa @akalenyu @kubevirt-bot @ShellyKa13