Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate cpumanager at kind workers #316

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Activate cpumanager at kind workers #316

merged 1 commit into from
Mar 19, 2020

Conversation

qinqon
Copy link
Contributor

@qinqon qinqon commented Mar 19, 2020

Signed-off-by: Quique Llorente ellorent@redhat.com

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Mar 19, 2020
@qinqon
Copy link
Contributor Author

qinqon commented Mar 19, 2020

/hold
Not working, looks like a kind bug.

@kubevirt-bot kubevirt-bot added size/S do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 19, 2020
@qinqon
Copy link
Contributor Author

qinqon commented Mar 19, 2020 •
edited
Loading

Let's wait for answer on kid issue
kubernetes-sigs/kind#1424

@qinqon
Activate cpumanager at kind workers
f521d7e 
Signed-off-by: Quique Llorente <ellorent@redhat.com>
@qinqon
Copy link
Contributor Author

qinqon commented Mar 19, 2020

/hold cancel

this works now.

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2020
@qinqon
Copy link
Contributor Author

qinqon commented Mar 19, 2020

/cc @ormergi

@ormergi
Copy link
Contributor

ormergi commented Mar 19, 2020

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2020
phoracek
phoracek approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@phoracek phoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

neat

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2020
@phoracek
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot merged commit 4e9997a into kubevirt:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoracek phoracek phoracek approved these changes

@danielBelenky danielBelenky Awaiting requested review from danielBelenky

@vladikr vladikr Awaiting requested review from vladikr

@ormergi ormergi Awaiting requested review from ormergi

Assignees

@phoracek phoracek

@ormergi ormergi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qinqon @ormergi @kubevirt-bot @phoracek