cni: add promiscous mode knob

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
kubevirt · Mar 31, 2023 · fdea0bf · fdea0bf
1 parent de5c9df
commit fdea0bf
Show file tree

Hide file tree

Showing 3 changed files with 54 additions and 4 deletions.
diff --git a/pkg/cni/plugin.go b/pkg/cni/plugin.go
@@ -33,8 +33,9 @@ import (
 // A NetConf structure represents a Multus network attachment definition configuration
 type NetConf struct {
 	types.NetConf
-	DeviceID string `json:"deviceID"`
-	MTU      int    `json:"mtu,omitempty"`
+	DeviceID      string `json:"deviceID"`
+	MTU           int    `json:"mtu,omitempty"`
+	IsPromiscuous bool   `json:"promiscMode,omitempty"`
 }
 
 // EnvArgs structure represents inputs sent from each VMI via environment variables
@@ -103,7 +104,7 @@ func CmdAdd(args *skel.CmdArgs) error {
 		}
 	}()
 
-	macvtapInterface, err := util.ConfigureInterface(netConf.DeviceID, args.IfName, mac, netConf.MTU, netns)
+	macvtapInterface, err := util.ConfigureInterface(netConf.DeviceID, args.IfName, mac, netConf.MTU, netConf.IsPromiscuous, netns)
 	if err != nil {
 		return err
 	}

diff --git a/pkg/cni/plugin_test.go b/pkg/cni/plugin_test.go
@@ -211,5 +211,48 @@ var _ = Describe("Macvtap CNI", func() {
 				})
 			})
 		})
+
+		Context("WHEN importing a macvtap interface into the target netns with promiscous mode enabled", func() {
+			const mtu = 1000
+
+			BeforeEach(func() {
+				promiscousModeArgs := fmt.Sprintf(`{
+				"cniVersion": "0.3.1",
+				"name": "mynet",
+				"type": "macvtap",
+				"deviceID": "%s",
+				"promiscMode": true
+			}`, deviceID)
+				args := &skel.CmdArgs{
+					ContainerID: "dummy",
+					Netns:       targetNs.Path(),
+					IfName:      deviceID,
+					StdinData:   []byte(promiscousModeArgs),
+				}
+
+				originalNS.Do(func(ns.NetNS) error {
+					defer GinkgoRecover()
+
+					_, _, err := testutils.CmdAdd(args.Netns, args.ContainerID, args.IfName, args.StdinData, func() error { return cni.CmdAdd(args) })
+					Expect(err).NotTo(HaveOccurred())
+
+					return nil
+				})
+			})
+
+			It("SHOULD successfully import the macvtap interface into the target netns, having the link promisc mode enabled", func() {
+				// confirm macvtap is available on target namespace, and the correct configurations were applied
+				targetNs.Do(func(ns.NetNS) error {
+					const enabled = 1
+					defer GinkgoRecover()
+
+					link, err := netlink.LinkByName(deviceID)
+					Expect(err).NotTo(HaveOccurred())
+					Expect(link.Attrs().Promisc).To(Equal(enabled))
+
+					return nil
+				})
+			})
+		})
 	})
 })
diff --git a/pkg/util/netlink.go b/pkg/util/netlink.go
@@ -227,7 +227,7 @@ func onLinkEvent(match func(netlink.Link) bool, nsPath string, do func(), stop <
 
 // Move an existing macvtap interface from the current netns to the target netns, and rename it..
 // Optionally configure the MAC address of the interface and the link's MTU.
-func ConfigureInterface(currentIfaceName string, newIfaceName string, macAddr *net.HardwareAddr, mtu int, netns ns.NetNS) (*current.Interface, error) {
+func ConfigureInterface(currentIfaceName string, newIfaceName string, macAddr *net.HardwareAddr, mtu int, promisc bool, netns ns.NetNS) (*current.Interface, error) {
 	var err error
 
 	macvtapIface, err := netlink.LinkByName(currentIfaceName)
@@ -263,6 +263,12 @@ func ConfigureInterface(currentIfaceName string, newIfaceName string, macAddr *n
 			}
 		}
 
+		if promisc {
+			if err := netlink.SetPromiscOn(macvtapIface); err != nil {
+				return fmt.Errorf("failed to enable promiscous mode on %q: %v", currentIfaceName, err)
+			}
+		}
+
 		renamedMacvtapIface, err := renameInterface(macvtapIface, newIfaceName)
 		if err != nil {
 			return err