needs-approver-review: avoid labelling PRs with changes requested #3763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub search currently lacks being able to query for PRs that are missing a review by an approver, since the concept of approver vs. reviewer is introduced via OWNERS, which GitHub doesn't know about. This change adds a condition to the search query that selects PRs to label with `needs-approver-review` in order to exclude PRs where changes have been requested. Signed-off-by: Daniel Hiller <dhiller@redhat.com>
|
Skipping CI for Draft Pull Request. |
kubevirt-bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Nov 15, 2024
kubevirt-bot
removed
the
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
GitHub search currently lacks being able to query for PRs that are missing a review by an approver, since the concept of approver vs. reviewer is enforced via OWNERS, which GitHub doesn't know about.
This change adds a condition to the search query that selects PRs to label with
needs-approver-reviewin order to exclude PRs where changes have been requested.Important
For this to work approvers need to explicitly request changes on the review though
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/cc @jean-edouard @brianmcarey
FYI @vladikr @alicefr