-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
labels,sig/compute: migrate sig/virtualization #3764
base: main
Are you sure you want to change the base?
labels,sig/compute: migrate sig/virtualization #3764
Conversation
The label `sig/virtualization`i [1] seems to be a leftover from previous times - we should migrate it into the sig/compute label. [1]: https://github.com/kubevirt/kubevirt/labels?q=sig%2Fvirtualization Signed-off-by: Daniel Hiller <dhiller@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you @dhiller! Looks great! WDYT about addressing the other sig labels as well as discussed here #2764 (comment)? |
@iholder101 I was thinking about asking the community before doing this - however, this shouldn't block this PR. WDYT? |
/override pull-project-infra-prow-deploy-test since it's not relevant |
@dhiller: Overrode contexts on behalf of dhiller: pull-project-infra-prow-deploy-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Yeah I agree it shouldn't block it. Thanks @dhiller! |
What this PR does / why we need it:
The label
sig/virtualization
i 1 seems to be a leftover from previous times - we should migrate it into the sig/compute label.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/cc @iholder101 @vladikr @brianmcarey