Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labels,sig/compute: migrate sig/virtualization #3764

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Nov 15, 2024

What this PR does / why we need it:

The label sig/virtualizationi 1 seems to be a leftover from previous times - we should migrate it into the sig/compute label.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @iholder101 @vladikr @brianmcarey

The label `sig/virtualization`i [1] seems to be a leftover from previous
times - we should migrate it into the sig/compute label.

[1]: https://github.com/kubevirt/kubevirt/labels?q=sig%2Fvirtualization

Signed-off-by: Daniel Hiller <dhiller@redhat.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Nov 15, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from dhiller. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iholder101
Copy link
Contributor

Thank you @dhiller! Looks great!

WDYT about addressing the other sig labels as well as discussed here #2764 (comment)?

@dhiller
Copy link
Contributor Author

dhiller commented Nov 18, 2024

Thank you @dhiller! Looks great!

WDYT about addressing the other sig labels as well as discussed here #2764 (comment)?

@iholder101 I was thinking about asking the community before doing this - however, this shouldn't block this PR. WDYT?

@dhiller
Copy link
Contributor Author

dhiller commented Nov 18, 2024

/override pull-project-infra-prow-deploy-test

since it's not relevant

@kubevirt-bot
Copy link
Contributor

@dhiller: Overrode contexts on behalf of dhiller: pull-project-infra-prow-deploy-test

In response to this:

/override pull-project-infra-prow-deploy-test

since it's not relevant

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iholder101
Copy link
Contributor

Thank you @dhiller! Looks great!
WDYT about addressing the other sig labels as well as discussed here #2764 (comment)?

@iholder101 I was thinking about asking the community before doing this - however, this shouldn't block this PR. WDYT?

Yeah I agree it shouldn't block it.
/lgtm

Thanks @dhiller!

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants