Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set special labels to dependabot PRs #835

Merged
merged 1 commit into from
Jan 17, 2024
Merged

feat: set special labels to dependabot PRs #835

merged 1 commit into from
Jan 17, 2024

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented Jan 15, 2024 •
edited
Loading

What this PR does / why we need it:
feat: set special labels to dependabot PRs

Set release-note-none label to
prs which were created by dependabot

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Jan 15, 2024
akrejcir
akrejcir reviewed Jan 16, 2024
View reviewed changes
.github/workflows/dependabot-ok-to-test.yaml Outdated
steps:
- name: Dependabot metadata
id: metadata
uses: dependabot/fetch-metadata@v1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The metadata is not used anywhere.

Copy link
Collaborator

@akrejcir akrejcir Jan 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now, it's explained here: https://github.com/dependabot/fetch-metadata?tab=readme-ov-file#auto-approving

Can you add a comment in to code explaining this?

@ksimon1
Copy link
Member Author

ksimon1 commented Jan 17, 2024

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2024
@ksimon1
feat: set special labels to dependabot PRs
28fbfaf 
Set release-note-none label to
prs which were created by dependabot

Signed-off-by: Karel Simon <ksimon@redhat.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ksimon1
Copy link
Member Author

ksimon1 commented Jan 17, 2024

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2024
@akrejcir
Copy link
Collaborator

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
0xFelix
0xFelix approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Btw. if we wanted to create a meaningful release note, IIRC you can also put the release note into the commit message.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2024
@kubevirt-bot kubevirt-bot merged commit 7ca439a into kubevirt:main Jan 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrejcir akrejcir akrejcir left review comments

@0xFelix 0xFelix 0xFelix approved these changes

@codingben codingben Awaiting requested review from codingben

@opokornyy opokornyy Awaiting requested review from opokornyy

Assignees

@0xFelix 0xFelix

@akrejcir akrejcir

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ksimon1 @akrejcir @kubevirt-bot @0xFelix