add attach PVC without clone functionality + refactor naming

[atiratree]

moving the conversation from #241 to here.

The current state:
Attach Disk -> clones and attaches PVC
Provision source IMAGE -> clones and boots from PVC

The new flow of storage tab should take this into account and add a possibility to attach PVC without cloning and to unify the naming across the whole UI.

[atiratree]

@aglitke @matthewcarleton

[matthewcarleton]

Do we need both the concept of attach and clone or can we just stick with clone? If so I think what we have proposed for the storage step makes sense (add versus create and attach). Is there a benefit to attaching without cloning?

[atiratree]

Do we need both the concept of attach and clone or can we just stick with clone?

cc @jelkosz

If so I think what we have proposed for the storage step makes sense (add versus create and attach).

I agree; to click add and then choose the specifics. There could be also an option/checkbox for cloning.

Is there a benefit to attaching without cloning?

There is. Users can create/import their own PVCs and wish to use it only in their one VM. Forcing cloning leads to wasting storage space.

[matthewcarleton]

There is. Users can create/import their own PVCs and wish to use it only in their one VM. Forcing cloning leads to wasting storage space.

so it seems like we will want to offer both clone and attach. We could go with @aglitke suggestion of clone disk and attach disk. In storage when selecting we can add an clone this disk checkbox. Does that make sense?

[atiratree]

it does if I understand it correctly. So we would add CLONE_DISK as a provisioning source now and then fix/implement the storage tab in the future.

[matthewcarleton]

yes, I believe so. I'd like @aglitke thoughts on this too, but that makes sense to me.

[atiratree]

changed to Cloned Disk in #291

[kubevirt-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[kubevirt-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

[kubevirt-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

[kubevirt-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

[kubevirt-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

[kubevirt-bot]

@kubevirt-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.