This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 30
Add edit functionality to Vm Details overview #156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 472
💛 - Coveralls |
Pull Request Test Coverage Report for Build 434
💛 - Coveralls |
rawagner
changed the title
Add edit functionality to Vm Details overview
WIP: Add edit functionality to Vm Details overview
Jan 4, 2019
rawagner
force-pushed
the
vm-details-edit
branch
from
January 4, 2019 12:39
5bca30d
to
af89574
Compare
rawagner
force-pushed
the
vm-details-edit
branch
8 times, most recently
from
January 7, 2019 08:28
d592fba
to
0416a25
Compare
rawagner
changed the title
WIP: Add edit functionality to Vm Details overview
Add edit functionality to Vm Details overview
Jan 7, 2019
rawagner
force-pushed
the
vm-details-edit
branch
from
January 8, 2019 08:12
0416a25
to
37fd258
Compare
mareklibra
reviewed
Jan 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
|
||
import { getDescription } from '../../../utils'; | ||
import { InlineEdit } from '../../InlineEdit'; | ||
import { Loading } from '../../Loading/Loading'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use index.js
LoadingComponent={LoadingComponent} | ||
onFormChange={(newValue, key) => onFormChange(newValue, key, true)} | ||
> | ||
{getDescription(vm) || 'VM has no description'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistence, we should use DASHES
rawagner
force-pushed
the
vm-details-edit
branch
from
January 8, 2019 12:44
7c62405
to
7297841
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.