Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

Add edit functionality to Vm Details overview #156

Merged
merged 2 commits into from
Jan 8, 2019

Conversation

rawagner
Copy link
Contributor

@rawagner rawagner commented Jan 4, 2019

No description provided.

@coveralls
Copy link

coveralls commented Jan 4, 2019

Pull Request Test Coverage Report for Build 472

  • 161 of 169 (95.27%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 87.234%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Details/Flavor/Flavor.js 45 47 95.74%
src/components/Details/VmDetails/VmDetails.js 32 38 84.21%
Totals Coverage Status
Change from base Build 471: 0.7%
Covered Lines: 1559
Relevant Lines: 1710

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 434

  • 63 of 122 (51.64%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.3%) to 82.683%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Form/FormFactory.js 2 3 66.67%
src/components/InlineEdit/InlineEdit.js 6 8 75.0%
src/components/Flavor/Flavor.js 36 40 90.0%
src/components/Details/VmDetails/VmDetails.js 11 37 29.73%
src/utils/utils.js 2 28 7.14%
Totals Coverage Status
Change from base Build 431: -3.3%
Covered Lines: 1363
Relevant Lines: 1566

💛 - Coveralls

@rawagner rawagner changed the title Add edit functionality to Vm Details overview WIP: Add edit functionality to Vm Details overview Jan 4, 2019
@rawagner rawagner force-pushed the vm-details-edit branch 8 times, most recently from d592fba to 0416a25 Compare January 7, 2019 08:28
@rawagner rawagner changed the title WIP: Add edit functionality to Vm Details overview Add edit functionality to Vm Details overview Jan 7, 2019
Copy link
Contributor

@mareklibra mareklibra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM


import { getDescription } from '../../../utils';
import { InlineEdit } from '../../InlineEdit';
import { Loading } from '../../Loading/Loading';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use index.js

LoadingComponent={LoadingComponent}
onFormChange={(newValue, key) => onFormChange(newValue, key, true)}
>
{getDescription(vm) || 'VM has no description'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistence, we should use DASHES

@mareklibra mareklibra merged commit 7b146b9 into kubevirt:master Jan 8, 2019
@rawagner rawagner deleted the vm-details-edit branch January 29, 2019 09:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants