This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
Add CreateNicRow component #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 478
💛 - Coveralls |
rawagner
force-pushed
the
add_nic_details
branch
from
3e9caed
to
ec85b48
Compare
rawagner
force-pushed
the
add_nic_details
branch
3 times, most recently
from
86ddd33
to
f20fd34
Compare
mareklibra
reviewed
Jan 8, 2019
| model: { | ||
| id: 'nic-model', | ||
| type: 'label', | ||
| value: get(nic.bus, 'value'), |
|
LGTM except small nitpicking |
rawagner
force-pushed
the
add_nic_details
branch
from
c13ae68
to
0e59603
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.