Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

Set template namespace to VM namespace #206

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

rawagner
Copy link
Contributor

@rawagner rawagner commented Feb 4, 2019

No description provided.

@coveralls
Copy link

coveralls commented Feb 4, 2019

Pull Request Test Coverage Report for Build 760

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 87.631%

Totals Coverage Status
Change from base Build 758: 0.008%
Covered Lines: 1891
Relevant Lines: 2068

💛 - Coveralls

@mareklibra
Copy link
Contributor

I'm not sure if I understand this change. When is this needed?
No matter the template is from, the VM should be created within actual namespace.

@rawagner
Copy link
Contributor Author

rawagner commented Feb 4, 2019

we are posting template to ProcessedTempates endpoint before VM creation. This endpoint will resolve all template parameters and returns processed template which is then used to create VM.
There is an issue in case of common-templates which are living in openshift namespace. Default user can read those templates but cannot post to that namespace. In order to be able to use ProcessedTemplates endpoint, we need to change template's namespace to the one which is accessible to user - namespace of VM

@atiratree atiratree merged commit 862b28a into kubevirt:master Feb 4, 2019
rawagner added a commit to rawagner/web-ui-components that referenced this pull request Feb 4, 2019
rawagner added a commit to rawagner/web-ui-components that referenced this pull request Feb 4, 2019
rawagner added a commit to rawagner/web-ui-components that referenced this pull request Feb 4, 2019
atiratree pushed a commit that referenced this pull request Feb 4, 2019
…rocessedTemplates (#207)

* Move mocked templates to openshift namespace. (#203)

Use ProjectModel instead of NamespaceModel when requesting resources.

* Set template namespace to VM namespace when posting to ProcessedTemplates endpoint (#206)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants