Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

Add binding type to NICs #298

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Conversation

rawagner
Copy link
Contributor

@rawagner rawagner commented Apr 1, 2019

No description provided.

@coveralls
Copy link

coveralls commented Apr 1, 2019

Pull Request Test Coverage Report for Build 1195

  • 44 of 62 (70.97%) changed or added relevant lines in 9 files are covered.
  • 7 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.3%) to 87.46%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Table/TableFactory.js 1 2 50.0%
src/k8s/vmBuilder.js 8 12 66.67%
src/selectors/vm/selectors.js 5 9 55.56%
src/components/CreateNicRow/CreateNicRow.js 8 17 47.06%
Files with Coverage Reduction New Missed Lines %
src/selectors/vm/selectors.js 1 85.37%
src/components/CreateNicRow/CreateNicRow.js 1 72.97%
src/components/Details/VmTemplateDetails/VmTemplateDetails.js 2 84.21%
src/components/Details/VmDetails/VmDetails.js 3 87.97%
Totals Coverage Status
Change from base Build 968: -0.3%
Covered Lines: 3044
Relevant Lines: 3334

💛 - Coveralls

@rawagner rawagner force-pushed the network_bind branch 2 times, most recently from 5df1d21 to e224696 Compare April 2, 2019 08:09
@mareklibra mareklibra merged commit 2de43ce into kubevirt:master Apr 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants