Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

Adding Capacity Card to Storage Overview #318

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

AyushAmbastha
Copy link
Contributor

@AyushAmbastha AyushAmbastha commented Apr 8, 2019

Added Capacity card to show 'Total capacity' in the form of a donut chart.

Screenshot from 2019-04-08 16-33-15

Tasks yet to be done as suggested by @julienlim@redhat.com -

  1. Change the font of 'Total Capacity' title to a smaller one. The text should be smaller than the card title 'Capacity'.
  2. Change GB to GiB.
    How do I go about it?

These changes will be sent in a following patch.
Also, I'll send a PR in kubevirt/web-ui for the same and reference this there.

@rawagner
Copy link
Contributor

rawagner commented Apr 8, 2019

@AyushAmbastha you can change units to *iB format here https://github.com/kubevirt/web-ui-components/blob/master/src/utils/utils.js#L85 but it will affect all units we have including network traffic so for example GBps will became GiBps. @andybraren I think that is OK, but to make sure..

@AyushAmbastha
Copy link
Contributor Author

Update: Integration in kubevirt/web-ui also done kubevirt/web-ui#273

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1083

  • 5 of 6 (83.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 87.283%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/StorageOverview/Capacity/Capacity.js 5 6 83.33%
Totals Coverage Status
Change from base Build 1297: -0.02%
Covered Lines: 3196
Relevant Lines: 3511

💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 9, 2019

Pull Request Test Coverage Report for Build 1309

  • 5 of 6 (83.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 87.283%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/StorageOverview/Capacity/Capacity.js 5 6 83.33%
Totals Coverage Status
Change from base Build 1297: -0.02%
Covered Lines: 3196
Relevant Lines: 3511

💛 - Coveralls

@rawagner rawagner merged commit 2651b20 into kubevirt:master Apr 9, 2019
@andybraren
Copy link

andybraren commented Apr 9, 2019

@AyushAmbastha you can change units to *iB format here https://github.com/kubevirt/web-ui-components/blob/master/src/utils/utils.js#L85 but it will affect all units we have including network traffic so for example GBps will became GiBps. @andybraren I think that is OK, but to make sure..

@rawagner I personally think the IEC unit (*iB) is better, but OKD currently uses the same labels that are in the YAML - abbreviated "Gi" or "Ti" without the "B" at the end. We should probably align with the rest of OKD for now until we open up that debate in the future. 😄

Network traffic is the one place where SI units (Mbps/Gbps) is still the industry standard, and I can't remember ever seeing Gibibits per second "Gibps" or Gibibytes per second "GiBps" in the real world. I just checked and it looks like Node Details pages within OKD use Kbps for network in/out taken from Prometheus data, so there is precedent for this.

From Node Details page:

2019-04-09 10 36 59

From Prometheus dashboard:

2019-04-09 10 36 35

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants