Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

Typo changes to storage dashboard #344

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Typo changes to storage dashboard #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions src/components/StorageOverview/Details/Details.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { getName } from '../../../selectors';
export const StorageDetails = ({ LoadingComponent, cephCluster }) => (
<DashboardCard>
<DashboardCardHeader>
<DashboardCardTitle>Details</DashboardCardTitle>
<DashboardCardTitle>OCS Details</DashboardCardTitle>
</DashboardCardHeader>
<DashboardCardBody>
<DetailsBody>
Expand All @@ -30,14 +30,7 @@ export const StorageDetails = ({ LoadingComponent, cephCluster }) => (
<DetailItem
key="provider"
title="Provider"
value="Ceph"
isLoading={false}
LoadingComponent={LoadingComponent}
/>
<DetailItem
key="ocs"
title="OCS version"
value="4.1" // this will be hardcoded for the demo
value="Bare Metal"
isLoading={false}
LoadingComponent={LoadingComponent}
/>
Expand Down
16 changes: 2 additions & 14 deletions src/components/StorageOverview/Details/tests/__snapshots__/Details.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ exports[`<Details /> renders correctly 1`] = `
<h2
class="card-pf-title"
>
Details
OCS Details
</h2>
</div>
<div
Expand Down Expand Up @@ -38,19 +38,7 @@ exports[`<Details /> renders correctly 1`] = `
class="kubevirt-detail__item-value"
>
<span>
Ceph
</span>
</dd>
<dt
class="kubevirt-detail__item-title"
>
OCS version
</dt>
<dd
class="kubevirt-detail__item-value"
>
<span>
4.1
Bare Metal
</span>
</dd>
</dl>
Expand Down
6 changes: 3 additions & 3 deletions src/components/StorageOverview/OCSHealth/HealthBody.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,17 @@ import { get } from 'lodash';

const HealthStatus = {
0: {
message: 'OCS is Healthy',
message: 'OCS is healthy',
iconname: 'check-circle',
classname: 'ok',
},
1: {
message: 'OCS health is Degraded',
message: 'OCS is degraded',
iconname: 'exclamation-circle',
classname: 'warning',
},
2: {
message: 'OCS health is in Error State',
message: 'OCS health is in error state',
iconname: 'exclamation-triangle',
classname: 'error',
},
Expand Down
2 changes: 1 addition & 1 deletion src/components/StorageOverview/Utilization/Utilization.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export const Utilization = ({ iopsUtilization, latencyUtilization, throughputUti
return (
<DashboardCard>
<DashboardCardHeader>
<DashboardCardTitle>OCS Perfrormance</DashboardCardTitle>
<DashboardCardTitle>Perfrormance</DashboardCardTitle>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These mockups have OCS Performance https://docs.google.com/presentation/d/15nDG3VuQRy6vJbMX4yq6ZvJ5G2Qawaz9glnLT8GEvX4/edit#slide=id.g4d3241551c_0_57 is there something newer ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rawagner Yesterday we had a demo and we received this in the feedback. The feedback is collected in the doc[1].

https://docs.google.com/document/d/1fCLn9RM5yF5nvZuqqCDKdt-PzvjDohCkX1Jnh6yI560/edit

</DashboardCardHeader>
<DashboardCardBody>
<UtilizationBody>
Expand Down
4 changes: 2 additions & 2 deletions src/components/StorageOverview/Utilization/tests/__snapshots__/Utilization.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ exports[`<Utilization /> renders correctly 1`] = `
<h2
class="card-pf-title"
>
OCS Perfrormance
Perfrormance
</h2>
</div>
<div
Expand Down Expand Up @@ -121,7 +121,7 @@ exports[`<Utilization /> renders correctly in Loading state 1`] = `
<h2
class="card-pf-title"
>
OCS Perfrormance
Perfrormance
</h2>
</div>
<div
Expand Down
18 changes: 3 additions & 15 deletions src/components/StorageOverview/tests/__snapshots__/StorageOverview.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ exports[`<StorageOverview /> renders correctly with Provider 1`] = `
<h2
class="card-pf-title"
>
Details
OCS Details
</h2>
</div>
<div
Expand Down Expand Up @@ -54,19 +54,7 @@ exports[`<StorageOverview /> renders correctly with Provider 1`] = `
class="kubevirt-detail__item-value"
>
<span>
Ceph
</span>
</dd>
<dt
class="kubevirt-detail__item-title"
>
OCS version
</dt>
<dd
class="kubevirt-detail__item-value"
>
<span>
4.1
Bare Metal
</span>
</dd>
</dl>
Expand Down Expand Up @@ -244,7 +232,7 @@ exports[`<StorageOverview /> renders correctly with Provider 1`] = `
<h2
class="card-pf-title"
>
OCS Perfrormance
Perfrormance
</h2>
</div>
<div
Expand Down