This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
updates:dashboard #352
Merged
updates:dashboard #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
needs-rebase
Pull Request Test Coverage Report for Build 1487
💛 - Coveralls |
atiratree
suggested changes
Apr 15, 2019
| text-align: center; | ||
| max-height: 130px; | ||
| /* stylelint-disable plugin/selector-bem-pattern */ | ||
| .kubevirt-cluster-overview__health-grid { |
There was a problem hiding this comment.
can we update StorageOverview/ocs-health.scss for consitency? or unite these two together into one file?
There was a problem hiding this comment.
@matthewcarleton I've updated snapshots etc to make the build pass. As @suomiy said, can you please update ocs-health.scss in this PR too ? For other changes I'd suggest to create a new branch and new PR to divide style changes to smaller pieces.
There was a problem hiding this comment.
Yes, I can do that. Thanks @suomiy
There was a problem hiding this comment.
Sorry this got larger than it should have. I'll create a new PR for the following updates.
kubevirt-bot
added
the
needs-rebase
kubevirt-bot
added
size/XXL
and removed
needs-rebase
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a simple one to test :)