This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
plotted y values for performance card graphs #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnehapk
force-pushed
the
performance-card-fix
branch
from
a56f21a
to
bebf82a
Compare
rawagner
suggested changes
Apr 25, 2019
| chartAxis = ( | ||
| <ChartAxis | ||
| dependentAxis | ||
| tickValues={[0, Number((maxY / 2).toFixed(decimalPoints)), Number(maxY.toFixed(decimalPoints))]} |
There was a problem hiding this comment.
if/else block could calculate just tickValues which would result in one ChartAxis definition (easier to maintain if the future)
Pull Request Test Coverage Report for Build 1670
💛 - Coveralls |
gnehapk
force-pushed
the
performance-card-fix
branch
from
bebf82a
to
6f0c302
Compare
|
Done the review changes. @rawagner Please review. |
rawagner
approved these changes
Apr 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, performance card will look like -
