This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
v2v: Compose image name dynamically #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1462
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1710
💛 - Coveralls |
rawagner
approved these changes
Apr 29, 2019
atiratree
approved these changes
Apr 29, 2019
|
prettier complains.. |
atiratree
reviewed
Apr 29, 2019
src/config/index.js
Outdated
|
|
||
| const getRegistry = () => { | ||
| const registry = get(window, 'SERVER_FLAGS.registry'); | ||
| if (!registry) { |
There was a problem hiding this comment.
we should not forget to setup SERVER_FLAGS for tests and cosmos next time. Or alternatively set a default value here.
atiratree
reviewed
Apr 29, 2019
src/config/index.js
Outdated
| }; | ||
|
|
||
| const getRegistryV2v = () => get(getRegistry(), 'v2v.url'); | ||
| const getImageTagConversion = () => get(getRegistry(), 'v2v.conversionTag'); |
There was a problem hiding this comment.
image tags could have a default value latest
|
Info: Working on better approach via ConfigMap |
Allows downstream patches.
atiratree
approved these changes
Apr 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows downstream patches.