Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

Capacity Card Dropdown #475

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Capacity Card Dropdown #475

merged 1 commit into from
Jun 19, 2019

Conversation

AyushAmbastha
Copy link
Contributor

@AyushAmbastha AyushAmbastha commented May 23, 2019 •
edited
Loading

Implemented the dropdown options for the Capacity card.

  1. Total Capacity
  2. Requested vs Used
  3. VMs vs Pods

Screenshot from 2019-06-04 16-31-31

The queries haven't been tested yet and will be changed, if needed.

@coveralls
Copy link

coveralls commented May 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1781

  • 14 of 16 (87.5%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 82.809%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/StorageOverview/Capacity/Capacity.js 11 13 84.62%
Totals Coverage Status
Change from base Build 1772: 0.002%
Covered Lines: 3995
Relevant Lines: 4622
💛 - Coveralls

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2019
@AyushAmbastha AyushAmbastha changed the title [WIP] Capacity Card Dropdown Capacity Card Dropdown Jun 4, 2019
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2019
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2019
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2019
@AyushAmbastha AyushAmbastha force-pushed the capacity-dropdown branch 2 times, most recently from 584538b to de4b1d7 Compare June 18, 2019 10:08
rawagner
rawagner suggested changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@rawagner rawagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the import issue, LGTM

src/components/StorageOverview/Capacity/Capacity.js Outdated Show resolved Hide resolved
@AyushAmbastha
Copy link
Contributor Author

@rawagner Done! :)

@rawagner rawagner merged commit 6cd0967 into kubevirt:master Jun 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rawagner rawagner rawagner requested changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AyushAmbastha @coveralls @rawagner @kubevirt-bot