Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

Fix save vCenter credentials functionality #493

Merged

Conversation

pcbailey
Copy link
Contributor

@pcbailey pcbailey commented Jun 7, 2019

This PR fixes an issue where vCenter credentials are not saved unless the create VM wizard is completed, regardless of success or failure. These changes cause the kubevirt.io/temporary label to be removed from the secret if the "Remember vCenter credentials" box is checked and adds the label with a value of true if the "Remember vCenter credentials" box is unchecked; however, these changes are only made if the connection check is successful.

Bug: https://bugzilla.redhat.com/1714004

Depends on: kubevirt/web-ui#399

Original PR: #489

@coveralls
Copy link

coveralls commented Jun 7, 2019

Pull Request Test Coverage Report for Build 1753

  • 26 of 44 (59.09%) changed or added relevant lines in 7 files are covered.
  • 53 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-1.3%) to 81.434%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/k8s/requests/v2v/createV2VvmwareObject.js 0 1 0.0%
src/k8s/requests/v2v/importVmware.js 0 4 0.0%
src/components/Wizard/CreateVmWizard/stateUpdate/providers/vmWareStateUpdate.js 9 22 40.91%
Files with Coverage Reduction New Missed Lines %
src/k8s/util/utils.js 2 60.0%
src/k8s/objects/v2v/vmware/vmWareSecret.js 4 9.09%
src/k8s/request.js 5 80.97%
src/k8s/requests/v2v/utils.js 8 5.0%
src/k8s/requests/v2v/importVmware.js 34 9.59%
Totals Coverage Status
Change from base Build 2027: -1.3%
Covered Lines: 3882
Relevant Lines: 4559

💛 - Coveralls

@mareklibra
Copy link
Contributor

This backport comes without snapshots from #489.
As activity on the stable branch is getting lower and lower and bug-fix release is requested to be asap, let's accept that.

@mareklibra mareklibra merged commit 6895dcd into kubevirt:web-ui-v2.0.0 Jun 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants