Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

Change PVC access mode to RWM #496

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

rawagner
Copy link
Contributor

@rawagner rawagner commented Jun 11, 2019

@coveralls
Copy link

coveralls commented Jun 11, 2019

Pull Request Test Coverage Report for Build 1760

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.434%

Totals Coverage Status
Change from base Build 1756: 0.0%
Covered Lines: 3882
Relevant Lines: 4559

💛 - Coveralls

@rawagner
Copy link
Contributor Author

Bug is not yet approved for backporting, so do not merge please

@rawagner rawagner added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2019
@mareklibra
Copy link
Contributor

@rawagner , what is the blocker for merge here?

@jelkosz
Copy link
Contributor

jelkosz commented Jun 11, 2019

@mareklibra nothing technical, it just needs to be decided that it should be targeted to 2.0. Will update here once the https://bugzilla.redhat.com/show_bug.cgi?id=1719134 has the correct flags

@jelkosz
Copy link
Contributor

jelkosz commented Jun 11, 2019

@mareklibra now the BZ is targeted to 2.0, you can merge :)

@jelkosz
Copy link
Contributor

jelkosz commented Jun 12, 2019

/hold
@mareklibra wait for it :) Maybe we should not merge this afterall, we would break the local storage use case with this.

@mareklibra mareklibra removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2019
@mareklibra
Copy link
Contributor

Per agreement, this is ready to land.

@mareklibra mareklibra merged commit d445c1c into kubevirt:web-ui-v2.0.0 Jun 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants